[3.10] Deprecation notice for tabstate #27067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple PR to add a deprecattion notice for JHtmlBehavior::tabstate cc @wilsonge
wilsonge
reviewed
Nov 14, 2019
libraries/cms/html/behavior.php
Outdated
| @@ -883,9 +883,13 @@ protected static function _getJSObject($array = array()) | |||
| * @return void | |||
| * | |||
| * @since 3.2 | |||
| * | |||
| * @Deprecated 4.0 Use the custom element joomla-tab. | |||
There was a problem hiding this comment.
lowercase on deprecated. Can we please add "in Joomla 4 use the custom element joomla-tab" as for now the custom elements don't exist in J3
|
Thanks! |
|
Thanks and thanks for fixing the bit I missed on my phone |
|
Np! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to add a deprecattion notice for JHtmlBehavior::tabstate
cc @wilsonge