[4.0] Skipto #24042
Closed
[4.0] Skipto #24042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[mod_articles_category] Showon
Fix OpenSearch implementation
[plg_user_profile] Add RTL check to ToS field
Fix sampledata menu creation
…21098) * Exceptions in Joomla\CMS\Table\Usergroup refer to categories Pull Request for Issue joomla#21092 . ### Summary of Changes remove todo that is clearly a copy paste error from somewhere else change exception message to usergroups from catergory NOTE the first exception` if ($this->id == 0)` I am not sure if that should even be present - doesn't look like it to me - please advise * Update Usergroup.php
) * correct video url fixes joomla#21145 (comment) * fix
* Speed up regex in emailcloak plugin * Fix comment
* Fix subform.repeatable-table multi field styling * Fix staging less/css * revert previous
…and update sites rebuild (joomla#16355) * Fix a problem with older language packs Language packs installed under older Joomla versions are registered in the database under their package name, not under their name and since rebuild function fails on them. e.g. package with <name>Afrikaans (South Africa)</name> <packagename>af-ZA</packagename> has name column in #_extensions table set as af-ZA and since existing query fails. * Update updatesites.php
|
@brianteeman try $document->addScriptDeclaration("document.addEventListener('DOMContentLoaded', function() {
window.skipToMenuInit(Joomla.getOptions('skipto-settings'));
});"); |
* [4.0] Postgresql date fix Correct the date used in a postgres sql file * installation
OK. Either way - make the javascript change I suggested - @dgrammatiko 's is wrong (that function doesn't take an options argument) Then see if the strings translate for you or not |
|
I will do after the rugby #priorities |
|
It's only important if scotland manage to upset :D :D |
|
@wilsonge Thanks!!!! The javascript is now working and like you I have had to add the $this->loadLanguage() I am going to work on adding options etc in the plugin now |
Quy
reviewed
Mar 9, 2019
| $current_section = 0; | ||
| } | ||
|
|
||
| if (!($current_section & $section)) |
There was a problem hiding this comment.
Suggested change
| if (!($current_section & $section)) | |
| if (!($current_section && $section)) |
joomla-cms-bot
added
Unit/System Tests
and removed
Language Change
|
See #24142 |
|
@wilsonge yeah for sure I'm wrong: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit - still a work in progress
@dgrammatiko Please advise/help on the addScriptOptions