Merge 3.8.11 Release into Joomla 4 #24068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[mod_articles_category] Showon
Fix OpenSearch implementation
[plg_user_profile] Add RTL check to ToS field
Fix sampledata menu creation
…21098) * Exceptions in Joomla\CMS\Table\Usergroup refer to categories Pull Request for Issue joomla#21092 . ### Summary of Changes remove todo that is clearly a copy paste error from somewhere else change exception message to usergroups from catergory NOTE the first exception` if ($this->id == 0)` I am not sure if that should even be present - doesn't look like it to me - please advise * Update Usergroup.php
) * correct video url fixes joomla#21145 (comment) * fix
* Speed up regex in emailcloak plugin * Fix comment
* Fix subform.repeatable-table multi field styling * Fix staging less/css * revert previous
…and update sites rebuild (joomla#16355) * Fix a problem with older language packs Language packs installed under older Joomla versions are registered in the database under their package name, not under their name and since rebuild function fails on them. e.g. package with <name>Afrikaans (South Africa)</name> <packagename>af-ZA</packagename> has name column in #_extensions table set as af-ZA and since existing query fails. * Update updatesites.php
…tact and newsfeeds (joomla#21180) * [3.x FIX] Getting the correct associations in sidebyside view for contact and newsfeeds * undefined property * correction in js
* [fix] fixed PluginHelper import of xtd-editors plugins * [imp] small adjustment and comment
* Don't need a closure, jQuery ready function is enough. Use strict. * Fix errors exposed by strict. Undeclared variables. wrong regex backreference * Fix some undeclared/wrongly declared variables * Avoid some redundant calls of $(this) * Remove some redundant (also wrong) code.
* make the text clealer Make the PLG_TWOFACTORAUTH_TOTP_STEP3_TEXT text clealer. * thans @brianteeman
PR for joomla#12448 ## Steps to reproduce the issue Effects all appended input fields. Eg. Navigate to a single article menu item (Menus -> MainMenu -> Home) and resize the screen below 767px. Input fields extend outside the viewport.
Fix for joomla#13678 reported by @gwsdesk
…accidental deletion with last release's post-update script
joomla-cms-bot
added
Language Change
brianteeman
reviewed
Mar 2, 2019
brianteeman
reviewed
Mar 2, 2019
| @@ -245,7 +246,9 @@ jQuery(document).ready(function($) { | |||
| var reference = document.getElementById('reference-association'); | |||
| var referenceId = reference.getAttribute('data-id'); | |||
| var languageCode = reference.getAttribute('data-language').replace(/-/, '_'); | |||
| var title = $(reference).contents().find('#jform_title').val(); | |||
| var target = document.getElementById('target-association'); | |||
There was a problem hiding this comment.
is this correct - there is var target a few lines later ??
There was a problem hiding this comment.
I mean the target is used on the next line here and then overridden after being used. Which seems like a bad naming convention for all kinds of reasons. But something to be fixed again outside the scope of this PR (same thing in staging https://github.com/joomla/joomla-cms/blob/staging/media/com_associations/js/sidebyside-uncompressed.js#L290-L293)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't squash merge as this will loose commit history. Only ever merge with a merge commit