Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] update Bootstrap to beta 2 #32378

Merged
merged 7 commits into from
Feb 11, 2021
Merged

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Feb 10, 2021

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@wilsonge

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Feb 10, 2021
@richard67
Copy link
Member

Boottrap? It explains a lot if it really is a trap ;-)

@dgrammatiko
Copy link
Contributor Author

giphy.mp4

@wilsonge wilsonge changed the title [4.0] update Boottrap to beta 2 [4.0] update Bootstrap to beta 2 Feb 10, 2021
@wilsonge
Copy link
Contributor

What's the popover change about. Obviously largely looks fine

@dgrammatiko
Copy link
Contributor Author

dgrammatiko commented Feb 10, 2021

What's the popover change about. Obviously largely looks fine

  • the $opt['offset'] = isset($options['offset']) ? $options['offset'] : [0, 0]; was initially removed from popovers as it was producing an error

  • The trigger is back to hover focus for all the elements that are supposed to present the popover on hover

  • There is a weird behaviour on the lists (articles, etc basically jGrid) and I think it's down to multiselect.js but that will need another PR Fixed, with proper delay values

@brianteeman
Copy link
Contributor

multiselect is broken anyway

@dgrammatiko
Copy link
Contributor Author

multiselect is broken anyway

might be but at this point the click events are mixed and the popovers are losing the proper target (at least this is my theory atm)

@Magnytu2
Copy link

Hello how to try this? I don't see a .zip file and cannot install it in the Joomla patch tester? Is it available in the night version of Joomla 4?

@infograf768
Copy link
Member

@dgrammatiko
Please update your branch as drone is blocked

@infograf768
Copy link
Member

Grr, drone still dead

add new line to trigger a new build
@rdeutz
Copy link
Contributor

rdeutz commented Feb 11, 2021

the special char in the description was the problem that drone didn't run

@richard67
Copy link
Member

@dgrammatiko If you have emojis in title or description of a PR, it can happen that ci jobs (here drone) don't work. In case of this PR it was the bell for calling George ;-)

@richard67
Copy link
Member

Hello how to try this? I don't see a .zip file and cannot install it in the Joomla patch tester? Is it available in the night version of Joomla 4?

@Magnytu2 In the nightly builds PRs which haven't been merged yet will never be included. But the zip files for this PR should be available now for testing.

@Magnytu2
Copy link

Yes I just tested and it works. The wok flow bubble has disappeared. Great, thank you very much to all the developer team.

@wilsonge wilsonge merged commit 6e46df9 into joomla:4.0-dev Feb 11, 2021
@wilsonge
Copy link
Contributor

Ok let’s get this in for wider testing. Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Feb 11, 2021
@Magnytu2
Copy link

@wilsonge @richard67 and ... Wouldn't it be time to switch to joomla! 4 RC. I think a lot of people would be more excited to test and escalate the issues. For extension developers too.

@brianteeman
Copy link
Contributor

@wilsonge
Copy link
Contributor

Basically what @brianteeman said @Magnytu2 - we need help fixing the release blockers before I feel comfortable releasing an RC - but yes I'd like to release one as soon as we work through the list of blockers

@dgrammatiko dgrammatiko deleted the 4.0-dev_bs5b2 branch February 19, 2021 10:36
@peteruoi
Copy link

@dgrammatiko
Copy link
Contributor Author

@peteruoi PR: #32827

@peteruoi
Copy link

Respect sir! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants