Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] BS beta 3 #32827

Merged
merged 7 commits into from
Mar 25, 2021
Merged

[4.0] BS beta 3 #32827

merged 7 commits into from
Mar 25, 2021

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Mar 23, 2021

Pull Request for Issue # .

Summary of Changes

Beta 3

Testing Instructions

Open the cassiopeia/index.php and add

HTMLHelper::_('bootstrap.offcanvas');
<button class="btn btn-primary" type="button" data-bs-toggle="offcanvas" data-bs-target="#offcanvasExample" aria-controls="offcanvasExample">
  <b>OFF-CANVAS-TEST</b>
</button>

<div class="offcanvas offcanvas-start" tabindex="-1" id="offcanvasExample" aria-labelledby="offcanvasExampleLabel">
  <div class="offcanvas-header">
    <h5 class="offcanvas-title" id="offcanvasExampleLabel">Offcanvas</h5>
    <button type="button" class="btn-close text-reset" data-bs-dismiss="offcanvas" aria-label="Close"></button>
  </div>
  <div class="offcanvas-body">
    <div>
      Some text as placeholder. In real life you can have the elements you have chosen. Like, text, images, lists, etc.
    </div>
  </div>
</div>

You should have an off canvas like:
Screenshot 2021-03-23 at 23 09 32

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

I wrote some documentation on using Bootstrap (the interactive parts) here: https://gist.github.com/dgrammatiko/efb3de4aa7cab4813a244f93f73cc0fd

If someone could move this to the Joomla docs I would appreciate it

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 23, 2021
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 51fb55e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Mar 23, 2021

I have tested this item ✅ successfully on 51fb55e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.

@Quy
Copy link
Contributor

Quy commented Mar 23, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.

@Quy Quy removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Mar 23, 2021
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 23, 2021
@dgrammatiko
Copy link
Contributor Author

@Quy please remove RTC. There is a new component in Bootstrap.
Will send the code in a bit

@Quy Quy removed the RTC This Pull Request is Ready To Commit label Mar 23, 2021
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Mar 23, 2021
@dgrammatiko
Copy link
Contributor Author

Ok support for off-canvas added

@laoneo
Copy link
Member

laoneo commented Mar 24, 2021

Guess we need here some more tests.

@Quy
Copy link
Contributor

Quy commented Mar 24, 2021

I have tested this item ✅ successfully on b179bd6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.

1 similar comment
@WebAtelier47
Copy link

I have tested this item ✅ successfully on b179bd6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.

@alikon
Copy link
Contributor

alikon commented Mar 25, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32827.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 25, 2021
@rdeutz rdeutz merged commit a5ed837 into joomla:4.0-dev Mar 25, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 25, 2021
@rdeutz rdeutz added this to the Joomla 4.0 milestone Mar 25, 2021
@dgrammatiko dgrammatiko deleted the 4.0-dev—bs3 branch March 25, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants