Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Simplify Requirements for Task Routine XMLs #36515

Merged
merged 7 commits into from
Jan 10, 2022

Conversation

ditsuke
Copy link
Contributor

@ditsuke ditsuke commented Jan 1, 2022

Pull Request for Issue #36449.

Summary of Changes

  • Fixes form for the Image Size Check task routine and improves a language string for clarity.
  • Removes requirement of the "showFront" attribute for the task_params fieldset.

Testing Instructions

  • Admin > System > Scheduled Tasks
  • Click "Create Task" or similar
  • Select "Image Size Check" routine
  • Fill in the form and save

Actual result BEFORE applying this Pull Request

  • Form fails to submit due to validation error (missing required data).
  • Routine XMLs require a showFront="true" attribute.

Expected result AFTER applying this Pull Request

  • Form is submitted, task is created.
  • Routine XMLs no longer require require the attribute to work correctly.

Documentation Changes Required

-

Fixes duplication of form field for routine configuration and failure to
validate and submit routine form.
Adds description to dimension limit (px) for clarity.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Jan 1, 2022
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 0d0c644


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@Shubhamverma2796
Copy link
Contributor

I have tested this item ✅ successfully on 8cdd8ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@jwaisner
Copy link
Member

jwaisner commented Jan 3, 2022

I have tested this item ✅ successfully on 8cdd8ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@jwaisner
Copy link
Member

jwaisner commented Jan 3, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 3, 2022
@ditsuke ditsuke changed the title [4.1] Fix Form for Image Size Check Task Routine [4.1] Simplify Requirements for Task Routine XMLs Jan 8, 2022
@ditsuke
Copy link
Contributor Author

ditsuke commented Jan 8, 2022

Needs tests again I believe

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 9f11de3

After the changes, everything works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@bembelimen
Copy link
Contributor

I have tested this item ✅ successfully on 9f11de3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@bembelimen bembelimen merged commit 993a2dc into joomla:4.1-dev Jan 10, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 10, 2022
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1 milestone Jan 10, 2022
@ditsuke ditsuke deleted the fix-image-size-form-sub branch January 15, 2022 19:30
heelc29 added a commit to heelc29/joomla that referenced this pull request Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants