Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] com_scheduler.ini - taskId #36700

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

tecpromotion
Copy link
Contributor

@tecpromotion tecpromotion commented Jan 15, 2022

Summary of Changes

Actually, the column is just called ID, but we also speak of the taskId in the context of logs. This PR adjusts the spelling, it just looks more professional :)

Testing Instructions

.

Actual result BEFORE applying this Pull Request

COM_SCHEDULER_CONFIG_GLOBAL_WEBCRON_LINK_DESC="By default, requesting this base link will only run tasks due for execution. To execute a specific task, use the task's ID as a query parameter appended to the URL: <code>BASE_URL&id=&lttask's id&gt</code>"

Expected result AFTER applying this Pull Request

COM_SCHEDULER_CONFIG_GLOBAL_WEBCRON_LINK_DESC="By default, requesting this base link will only run tasks due for execution. To execute a specific task, use the task's ID as a query parameter appended to the URL: <code>BASE_URL&id=&lt;taskId&gt;</code>"

Thanks @Quy for two ;

Documentation Changes Required

.

thanks @Quy

Co-authored-by: Quy <quy@fluxbb.org>
@tecpromotion tecpromotion requested a review from Quy January 15, 2022 20:14
@ditsuke
Copy link
Contributor

ditsuke commented Jan 15, 2022

I have tested this item ✅ successfully on 2399482

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36700.

@Quy
Copy link
Contributor

Quy commented Jan 15, 2022

I have tested this item ✅ successfully on 2399482


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36700.

@Quy
Copy link
Contributor

Quy commented Jan 15, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36700.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 15, 2022
@bembelimen bembelimen added this to the Joomla 4.1.0 milestone Jan 17, 2022
@bembelimen bembelimen merged commit 17dcc9f into joomla:4.1-dev Jan 17, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 17, 2022
@bembelimen
Copy link
Contributor

Thx

@tecpromotion tecpromotion deleted the patch-5 branch February 23, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants