-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Smart Search: Allow fuzzy word matching #36752
Conversation
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
please don't introduce magic numbers, define "words" in the xml and add constants to the class for matching the value. |
Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: Quy <quy@fluxbb.org>
I have tested this item 🔴 unsuccessfully on 7e56d0b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36752. |
Thank you, @superknutsel. There was indeed a bug in the code. Can you test this again? |
I have tested this item ✅ successfully on a1d1b4f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36752. |
Thank you very much. |
I have tested this item ✅ successfully on a1d1b4f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36752. |
Thanks |
joomla/joomla-cms#36591 + joomla/joomla-cms#37362 + joomla/joomla-cms#37404 - (позже был Revert PR) joomla/joomla-cms#37453 + joomla/joomla-cms#37583 + joomla/joomla-cms#37459 + joomla/joomla-cms#36751 + joomla/joomla-cms#36752 + joomla/joomla-cms#37912 + joomla/joomla-cms#37838 + joomla/joomla-cms#38002 + joomla/joomla-cms#38036 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#38009 + joomla/joomla-cms#38064 + joomla/joomla-cms#37911 + joomla/joomla-cms#38065 + joomla/joomla-cms#38075 + joomla/joomla-cms#38071 + joomla/joomla-cms#38080 + joomla/joomla-cms#38082 + joomla/joomla-cms#38092 + joomla/joomla-cms#38113 + joomla/joomla-cms#38121 + joomla/joomla-cms#37910 + joomla/joomla-cms#38165 + joomla/joomla-cms#37747 +
Summary of Changes
A regular request was to be able to also find compoung words. Smart Search right now matches the words exactly, even though it uses a stemmer to find common roots for a word. However those stemmers can only work on single words and "fail" on compound words, like they are very common in for example the german language. This PR allows to switch the matching method between exact matches, matching words starting with the given term and matching words which just contain the term in a random position. I was hoping that there would be a way to automatically split compound words in their different parts and to also index those, however I couldn't find a solution which could be used with justifiable effort. So this is the next best solution as it seems.
Testing Instructions
Notes