-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add captive prompts for the rest of MFA methods #38082
Merged
fancyFranci
merged 4 commits into
joomla:4.2-dev
from
nikosdion:feature/mfa-captive-prompts
Jun 18, 2022
Merged
Add captive prompts for the rest of MFA methods #38082
fancyFranci
merged 4 commits into
joomla:4.2-dev
from
nikosdion:feature/mfa-captive-prompts
Jun 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses comment #37912 (comment) Adds captive login prompts for these MFA methods: * Backup Codes * TOTP (Authenticator Code) * YubiKey The rest of the methods already had it: * Email * Fixed * WebAuthn
brianteeman
reviewed
Jun 17, 2022
Co-authored-by: Brian Teeman <brian@teeman.net>
brianteeman
reviewed
Jun 17, 2022
Co-authored-by: Brian Teeman <brian@teeman.net>
I have tested this item ✅ successfully on b5c7d4a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38082. |
1 similar comment
I have tested this item ✅ successfully on b5c7d4a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38082. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38082. |
Thank you for the improvement! |
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
Jun 23, 2022
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Jul 6, 2022
joomla/joomla-cms#36591 + joomla/joomla-cms#37362 + joomla/joomla-cms#37404 - (позже был Revert PR) joomla/joomla-cms#37453 + joomla/joomla-cms#37583 + joomla/joomla-cms#37459 + joomla/joomla-cms#36751 + joomla/joomla-cms#36752 + joomla/joomla-cms#37912 + joomla/joomla-cms#37838 + joomla/joomla-cms#38002 + joomla/joomla-cms#38036 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#38009 + joomla/joomla-cms#38064 + joomla/joomla-cms#37911 + joomla/joomla-cms#38065 + joomla/joomla-cms#38075 + joomla/joomla-cms#38071 + joomla/joomla-cms#38080 + joomla/joomla-cms#38082 + joomla/joomla-cms#38092 + joomla/joomla-cms#38113 + joomla/joomla-cms#38121 + joomla/joomla-cms#37910 + joomla/joomla-cms#38165 + joomla/joomla-cms#37747 +
zero-24
added a commit
to joomlagerman/joomla
that referenced
this pull request
Jul 21, 2022
#2483) * remove and add strings in existing files * add 10 new files plg_multifactorauth_* * translation plg_multifactorauth_email * translation plg_multifactorauth_fixed * translation plg_multifactorauth_totp * translation plg_twofactorauth_yubikey * translation plg_multifactorauth_webauthn * fix #2486 * file header * add strings joomla/joomla-cms#38082 * fix #2506 * unification Passwort-Manager * fix one Authentifikator * fix year * fix wording * fix joomla.ini * fix joomla.ini * fix joomla.ini * fix z. B. * fix com_users.ini translation * fix translation * fix Backup-Code * Update administrator/language/de-DE/plg_multifactorauth_email.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_email.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_email.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_email.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_email.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_email.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_email.sys.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_email.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_totp.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * revert * wording * wording * translation * Update administrator/language/de-DE/plg_multifactorauth_fixed.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_webauthn.sys.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_fixed.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_fixed.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_fixed.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_fixed.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_email.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Apply suggestions from code review Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Apply suggestions from code review Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Apply suggestions from code review Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_email.ini * Update administrator/language/de-DE/plg_multifactorauth_email.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/plg_multifactorauth_email.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/plg_multifactorauth_totp.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_totp.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_totp.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * fix link * Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * fix * fix * Update administrator/language/de-DE/com_users.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_users.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * fix * Update administrator/language/de-DE/plg_multifactorauth_fixed.sys.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_fixed.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Apply suggestions from code review Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/plg_multifactorauth_yubikey.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update language/de-DE/com_users.ini Co-authored-by: Dieter Ziller <max123kl@ziller.de> * Update administrator/language/de-DE/com_users.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_twofactorauth_totp.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_twofactorauth_totp.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_twofactorauth_yubikey.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_twofactorauth_yubikey.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update language/de-DE/com_users.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_multifactorauth_email.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_multifactorauth_email.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_multifactorauth_email.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_users.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_multifactorauth_fixed.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_multifactorauth_totp.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update language/de-DE/com_users.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_multifactorauth_fixed.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_multifactorauth_fixed.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/plg_multifactorauth_totp.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * add eo * Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update language/de-DE/com_users.ini * Update administrator/language/de-DE/com_users.ini * fix weil alle einen punkt haben Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com> Co-authored-by: Dieter Ziller <max123kl@ziller.de> Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for comment #37912 (comment).
Ping @Kostelano @richard67
Summary of Changes
Adds captive login prompts for these MFA methods:
The rest of the methods already had it:
Testing Instructions
Actual result BEFORE applying this Pull Request
Choosing to validate with backup codes, TOTP or YubiKey would only display a text box without any help text to help you understand what to do.
Expected result AFTER applying this Pull Request
There is help text above the text box explaining how to obtain the code and proceed with the MFA.
Documentation Changes Required
None
Adds language strings
These three methods didn't have a captive prompt language string. I added three strings.