Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.2] Multi-Factor Authentication (replaces Two Factor Authentication) #2483

Merged
merged 140 commits into from
Jul 21, 2022
Merged

[4.2] Multi-Factor Authentication (replaces Two Factor Authentication) #2483

merged 140 commits into from
Jul 21, 2022

Conversation

tecpromotion
Copy link
Member

@tecpromotion tecpromotion commented Jun 12, 2022 •
edited
Loading

Pull Request für Issue #2463 .

Zusammenfassung der Änderungen

  • remove and add strings in existing files
  • translation in existing files

add 10 new files and translate

  • plg_multifactorauth_yubikey.ini
  • plg_multifactorauth_yubikey.sys.ini
  • plg_multifactorauth_webauthn.ini
  • plg_multifactorauth_webauthn.sys.ini
  • plg_multifactorauth_totp.ini
  • plg_multifactorauth_totp.sys.ini
  • plg_multifactorauth_fixed.ini
  • plg_multifactorauth_fixed.sys.ini
  • plg_multifactorauth_email.sys.ini
  • plg_multifactorauth_email.sys.sys.ini

Wo wird der Sprachstring angezeigt / Wie kann getestet werden

all 3 regions

@tecpromotion
remove and add strings
9fe8633 
in existing files
@tecpromotion
add 10 new files
e031312 
plg_multifactorauth_*
@tecpromotion tecpromotion marked this pull request as draft June 12, 2022 09:46
@tecpromotion tecpromotion self-assigned this Jun 12, 2022
@tecpromotion tecpromotion added this to the 4.2.0v1 milestone Jun 12, 2022
@tecpromotion tecpromotion linked an issue Jun 12, 2022 that may be closed by this pull request
[4.2] Multi-Factor Authentication (replaces Two Factor Authentication) #2463
Closed
@tecpromotion tecpromotion linked an issue Jun 14, 2022 that may be closed by this pull request
[4.2] unification YubiKey vs Yubikey #2486
Closed
@heelc29 heelc29 linked an issue Jun 23, 2022 that may be closed by this pull request
[4.2] Add captive prompts for the rest of MFA methods #2506
Closed
max123kl
max123kl previously approved these changes Jul 20, 2022
View reviewed changes
heelc29
heelc29 reviewed Jul 21, 2022
View reviewed changes
Copy link
Member

@heelc29 heelc29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #2532

@tecpromotion @heelc29
Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini
d7b7821 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@tecpromotion @heelc29
Apply suggestions from code review
58d7610 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
zero-24
zero-24 previously approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@zero-24 zero-24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich denke wir sind hier jetzt good-to-merge was denkt Ihr @tecpromotion @heelc29 @max123kl ?

@heelc29
Copy link
Member

heelc29 commented Jul 21, 2022

Ich denke wir sind hier jetzt good-to-merge was denkt Ihr @tecpromotion @heelc29 @max123kl ?

Habs gerade mal in ne Testumgebung rein ... das schaut hier z.B. noch nicht optimal aus:
image

max123kl
max123kl previously approved these changes Jul 21, 2022
View reviewed changes
@tecpromotion
Copy link
Member Author

Ich denke wir sind hier jetzt good-to-merge was denkt Ihr @tecpromotion @heelc29 @max123kl ?

Habs gerade mal in ne Testumgebung rein ... das schaut hier z.B. noch nicht optimal aus: image

das schaut eher grottig aus. Danke @heelc29

tecpromotion
tecpromotion commented Jul 21, 2022
View reviewed changes
Copy link
Member Author

@tecpromotion tecpromotion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier haben wir im Deutschen ein Problem mit Hinzufügen einer neuen %s da wir 3 Fälle abdecken müssen.

@tecpromotion tecpromotion dismissed stale reviews from max123kl and zero-24 via 1d6aa49 July 21, 2022 16:47
@tecpromotion
Copy link
Member Author

Ich denke wir sind hier jetzt good-to-merge was denkt Ihr @tecpromotion @heelc29 @max123kl ?

good-to-merge = kann ja jederzeit optimiert werden.

@zero-24 oder @heelc29 einer von euch darf dann so frei sein 🥇

@tecpromotion
fix
6785491 
weil alle einen punkt haben
@zero-24
Copy link
Member

zero-24 commented Jul 21, 2022

Merging dank euch! @tecpromotion @max123kl @heelc29 💯

@zero-24 zero-24 merged commit a621eb1 into joomlagerman:4.2-dev Jul 21, 2022
@zero-24 zero-24 deleted the issue-2463 branch July 21, 2022 17:03
@tecpromotion tecpromotion linked an issue Jul 30, 2022 that may be closed by this pull request
[4.2] fix yubico.com link #2554
Closed
@tecpromotion tecpromotion mentioned this pull request Jul 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zero-24 zero-24 zero-24 approved these changes

@max123kl max123kl Awaiting requested review from max123kl

@heelc29 heelc29 Awaiting requested review from heelc29

Assignees

@tecpromotion tecpromotion

Labels
core language change Joomla! 4.x
Milestone
4.2.0v1
4 participants
@tecpromotion @max123kl @heelc29 @zero-24