Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/showon #37451

Merged
merged 24 commits into from
Aug 29, 2023
Merged

Fix/showon #37451

merged 24 commits into from
Aug 29, 2023

Conversation

toroworx
Copy link
Contributor

@toroworx toroworx commented Apr 1, 2022 •
edited
Loading

Pull Request for Issue # .
#37299

Summary of Changes

Fixed showon issue for nested options as described above.

Testing Instructions

#37300 (comment)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

none

This was referenced Apr 1, 2022
Closed
Closed
@richard67 richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022
@HLeithner HLeithner changed the base branch from 4.1-dev to 4.2-dev June 27, 2022 13:05
@richard67
Copy link
Member

I've allowed myself to fix the merge conflict after the rebase.

@HLeithner HLeithner removed the psr12 label Oct 23, 2022
@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@Quy Quy changed the base branch from 4.2-dev to 4.3-dev March 24, 2023 01:40
@Quy Quy added PR-4.3-dev and removed PR-4.2-dev labels Mar 24, 2023
@Hackwar Hackwar added the bug label Apr 6, 2023
@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Aug 25, 2023
@robinclapp
Copy link

I have tested this item ✅ successfully on fec38be

Note, that the other issue where status gets stuck when pinned inside com_banner edit

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37451.

@blanderson22
Copy link

I have tested this item ✅ successfully on fec38be

Note, that the other issue mentioned on GitHub, where status gets stuck when pinned inside com_banner edit, still exists.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37451.

@richard67 richard67 added PR-4.2-dev and removed PBF Pizza, Bugs and Fun bug PR-4.3-dev labels Aug 26, 2023
@richard67
Copy link
Member

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37451.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 26, 2023
@richard67 richard67 added bug PR-4.3-dev PBF Pizza, Bugs and Fun and removed PR-4.2-dev labels Aug 26, 2023
@obuisard obuisard added this to the Joomla! 4.3.5 milestone Aug 29, 2023
@obuisard obuisard merged commit d6e533c into joomla:4.3-dev Aug 29, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 29, 2023
@obuisard
Copy link
Contributor

Thank you @toroworx for the PR!

@toroworx
Copy link
Contributor Author

You're most welcome! Thanks for testing and merging :-) @richard67 @robinclapp @blanderson22 @obuisard

HLeithner pushed a commit that referenced this pull request Sep 4, 2023
@laoneo @dgrammatiko
@crystalenka @heelc29 @Denitz @brianteeman @toroworx @MacJoom @BrainforgeUK @obuisard @chmst @ManuelHu @alikon @Hackwar @QuyTon @SniperSister @beefcakefu @Fedik @andyforrest
[5.0] Upmerge (#41584)
3fe66e6 
* fix calendar positioning (#41477)

* Update joomla-field-media.w-c.es6.js (#41361)

* Fixing md5 Deprecation in document.php (#39880)

* modal field check for danger alert (#39173)

* fix (#41138)

* [4.x] Cassiopeia Install SQL (#37389)

* Fix/showon (#37451)

* Bugfix for Issue #38599 - Smart Search indexing macros from articles (#38998)

* [4,3] joomla alert icons (#39312)

* Update StyleModel.php (#40665)

* Update Query.php (#40687)

* remove hitcount variable from uri after voting (#41474)

* Fix deprecated message in categories when extension is empty (#40604)

* Re-add minus to allowed filenames in com_templates (#41369)

* Invalid delete of all content articles from smart search index (#41288)

* [4][cli] schema update check (#40468)

* Tags: Don't put NULL into trim() (#41509)

Co-authored-by: Quy <quy@nomonkeybiz.com>

* [4] Add multilanguage filter taxonomy rows in com_finder advanced filters (#41470)

* Fix taxonomy filter options

* refactor rest of query to prepared statements

---------

Co-authored-by: Quy <quy@nomonkeybiz.com>

* Check if the pre update check box actually exists (#41467)

* Allow onValidateContact plugin to show error message (#37540)

* [4.4] Backward compatibility handling for plugins that setting the result directly (#41525)

* Backward compatibility handling for plugins that setting the result directly.

* Update libraries/src/Event/AbstractImmutableEvent.php

Co-authored-by: Brian Teeman <brian@teeman.net>

---------

* Tests for com_privacy consent on user site (#41529)

* Tests for com_privacy consent on user site

* Allow ability to enable extension in tests to prevent errors

* remove paramater not needed

* Added fixes to stop  errors in drone build

* Added fixes to stop  errors in drone build

* Added fixes to stop  errors in drone build

* [4.4] system test for com_installer (#41483)

* system test for com_installer

* cs

* Missing System Tests in #41362 (#41479)

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

added spaces and semicolons

* Update Categories.cy.js

Missing spaces and semicolons

* Update Categories.cy.js

Missing spaces and semicolons

* Update Categories.cy.js

Missing spaces and semicolons

* Update Categories.cy.js

removed tabs

* Update Categories.cy.js

Removed tabs

* Update Categories.cy.js

Removed tabs

* Update Categories.cy.js

Removed tabs

* Update Language.php (#41353)

* Filter for special characters that fail sending test mail (#41469)

* Backporting event changes (#41484)

Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

* api tests for endpoints for com_privacy consent (#41544)

* Show the plugin name in the update screen (#41537)

* Show the plugin name in the update screen

* cs

---------

* Replace the special characters in site name for mail templates (#41582)

* Updates the dependencies (#41538)

* Updating dependencies

* Major update cypress

* Thanks for the reminder @brianteeman

* Composer

* weekend updates

* Update dependencies

* Update incompatible HTML file

---------

Co-authored-by: Magnus Singer <magnussinger@icloud.com>
Co-authored-by: Dimitris Grammatikogiannis <d.grammatiko@gmail.com>
Co-authored-by: Crystal Dionysopoulos <9141288+crystalenka@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Denitz <197527+Denitz@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: toroworx <toroworx@users.noreply.github.com>
Co-authored-by: Martin Carl Kopp <6154099+MacJoom@users.noreply.github.com>
Co-authored-by: Jonathan Brain <3941269+BrainforgeUK@users.noreply.github.com>
Co-authored-by: Olivier Buisard <olivier.buisard@simplifyyourweb.com>
Co-authored-by: Christiane Maier-Stadtherr <dev@chmst.de>
Co-authored-by: Manuel Huber <ManuelHu@users.noreply.github.com>
Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com>
Co-authored-by: Hannes Papenberg <info@joomlager.de>
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: David Jardin <d.jardin@djumla.de>
Co-authored-by: beefcakefu <103491197+beefcakefu@users.noreply.github.com>
Co-authored-by: Fedir Zinchuk <getthesite@gmail.com>
Co-authored-by: andyforrest <46865032+andyforrest@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug PBF Pizza, Bugs and Fun Small A PR which only has a small change
Projects
None yet
Milestone
Joomla! 4.3.5
Development

Successfully merging this pull request may close these issues.