Fix allowed chars in mailer subject #41138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on e8b28cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41138. |
|
I have tested this item ✅ successfully on e8b28cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41138. |
|
I have an error sending a message with or without special characters in the subject after applying the patch. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41138. |
@Magnytu2 This error seems not to be related to the changes in this PR. On which version of Joomla have you tested? |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41138. |
|
I have tested this item ✅ successfully on e8b28cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41138. |
|
@richard67 test Joomla 5.0 Beta 1 - php 8.1.18 - 10.5.21 MariaDB. |
@Magnytu2 This pull request here is for the 4.3-dev branch, sou you cannot test it on a 5.0-beta1-dev. |
|
Thank you @Denitz for the PR! |
|
@obuisard Thank you! |
HLeithner
pushed a commit
that referenced
this pull request
Sep 4, 2023
* fix calendar positioning (#41477) * Update joomla-field-media.w-c.es6.js (#41361) * Fixing md5 Deprecation in document.php (#39880) * modal field check for danger alert (#39173) * fix (#41138) * [4.x] Cassiopeia Install SQL (#37389) * Fix/showon (#37451) * Bugfix for Issue #38599 - Smart Search indexing macros from articles (#38998) * [4,3] joomla alert icons (#39312) * Update StyleModel.php (#40665) * Update Query.php (#40687) * remove hitcount variable from uri after voting (#41474) * Fix deprecated message in categories when extension is empty (#40604) * Re-add minus to allowed filenames in com_templates (#41369) * Invalid delete of all content articles from smart search index (#41288) * [4][cli] schema update check (#40468) * Tags: Don't put NULL into trim() (#41509) Co-authored-by: Quy <quy@nomonkeybiz.com> * [4] Add multilanguage filter taxonomy rows in com_finder advanced filters (#41470) * Fix taxonomy filter options * refactor rest of query to prepared statements --------- Co-authored-by: Quy <quy@nomonkeybiz.com> * Check if the pre update check box actually exists (#41467) * Allow onValidateContact plugin to show error message (#37540) * [4.4] Backward compatibility handling for plugins that setting the result directly (#41525) * Backward compatibility handling for plugins that setting the result directly. * Update libraries/src/Event/AbstractImmutableEvent.php Co-authored-by: Brian Teeman <brian@teeman.net> --------- * Tests for com_privacy consent on user site (#41529) * Tests for com_privacy consent on user site * Allow ability to enable extension in tests to prevent errors * remove paramater not needed * Added fixes to stop errors in drone build * Added fixes to stop errors in drone build * Added fixes to stop errors in drone build * [4.4] system test for com_installer (#41483) * system test for com_installer * cs * Missing System Tests in #41362 (#41479) * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js added spaces and semicolons * Update Categories.cy.js Missing spaces and semicolons * Update Categories.cy.js Missing spaces and semicolons * Update Categories.cy.js Missing spaces and semicolons * Update Categories.cy.js removed tabs * Update Categories.cy.js Removed tabs * Update Categories.cy.js Removed tabs * Update Categories.cy.js Removed tabs * Update Language.php (#41353) * Filter for special characters that fail sending test mail (#41469) * Backporting event changes (#41484) Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * api tests for endpoints for com_privacy consent (#41544) * Show the plugin name in the update screen (#41537) * Show the plugin name in the update screen * cs --------- * Replace the special characters in site name for mail templates (#41582) * Updates the dependencies (#41538) * Updating dependencies * Major update cypress * Thanks for the reminder @brianteeman * Composer * weekend updates * Update dependencies * Update incompatible HTML file --------- Co-authored-by: Magnus Singer <magnussinger@icloud.com> Co-authored-by: Dimitris Grammatikogiannis <d.grammatiko@gmail.com> Co-authored-by: Crystal Dionysopoulos <9141288+crystalenka@users.noreply.github.com> Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> Co-authored-by: Denitz <197527+Denitz@users.noreply.github.com> Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: toroworx <toroworx@users.noreply.github.com> Co-authored-by: Martin Carl Kopp <6154099+MacJoom@users.noreply.github.com> Co-authored-by: Jonathan Brain <3941269+BrainforgeUK@users.noreply.github.com> Co-authored-by: Olivier Buisard <olivier.buisard@simplifyyourweb.com> Co-authored-by: Christiane Maier-Stadtherr <dev@chmst.de> Co-authored-by: Manuel Huber <ManuelHu@users.noreply.github.com> Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com> Co-authored-by: Hannes Papenberg <info@joomlager.de> Co-authored-by: Quy <quy@nomonkeybiz.com> Co-authored-by: David Jardin <d.jardin@djumla.de> Co-authored-by: beefcakefu <103491197+beefcakefu@users.noreply.github.com> Co-authored-by: Fedir Zinchuk <getthesite@gmail.com> Co-authored-by: andyforrest <46865032+andyforrest@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issues #31768, #40571.
Summary of Changes
Currently, email subject is validated as email address, hence it's impossible to send an email with a subject like
Test email for test@test.com {test}The problem is that email subject is incorrectly validated as email address since 2006, see dec8927#diff-89c219c58287d02dd7de50360cf6656e7ab96bfd20ef065ef54db235ff12dea4R127
Current
MailHelper::cleanSubject()was never used, we can use it.Testing Instructions
Send an email with subject
Test email for test@test.com {test}Actual result BEFORE applying this Pull Request
See error
Expected result AFTER applying this Pull Request
No errors
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed