-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Convert basic API auth plugin to services #37803
[4.2] Convert basic API auth plugin to services #37803
Conversation
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Can you please also correct the filenames of the language files in the manifest to: joomla-cms/plugins/api-authentication/basic/basic.xml Lines 16 to 17 in ee81859
|
…oomla-cms into j4/plugins/api-auth/basic
Done |
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cs
In other extensions the file in the |
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
…oomla-cms into j4/plugins/api-auth/basic
I have tested this item ✅ successfully on 94bbd50 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37803. |
I have tested this item ✅ successfully on 94bbd50 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37803. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37803. |
Thanks everybody |
Summary of Changes
Converts the basic API auth plugin to services.
Testing Instructions
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.