Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Convert basic API auth plugin to services #37803

Merged
merged 16 commits into from
May 21, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented May 15, 2022

Summary of Changes

Converts the basic API auth plugin to services.

Testing Instructions

  • Enable the basic API auth plugin
  • Make an API request with basic authentication, for example you can use curl or postman

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

@laoneo laoneo changed the title [4.2] Convert basic api auth plugin to services [4.2] Convert basic API auth plugin to services May 15, 2022
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@heelc29
Copy link
Contributor

heelc29 commented May 17, 2022

Can you please also correct the filenames of the language files in the manifest to: plg_api-authentication_basic(.sys).ini (wrong added in #23424 😅)

<language tag="en-GB">language/en-GB/plg_authentication_api_basic.ini</language>
<language tag="en-GB">language/en-GB/plg_authentication_api_basic.sys.ini</language>

@laoneo
Copy link
Member Author

laoneo commented May 17, 2022

Done

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
laoneo and others added 2 commits May 17, 2022 14:09
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Copy link
Contributor

@heelc29 heelc29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cs

@heelc29
Copy link
Contributor

heelc29 commented May 17, 2022

In other extensions the file in the src folder is in a subfolder Extension. Should it also?

laoneo and others added 4 commits May 17, 2022 14:23
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@heelc29
Copy link
Contributor

heelc29 commented May 17, 2022

I have tested this item ✅ successfully on 94bbd50

Thanks @laoneo


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37803.

@toivo
Copy link
Contributor

toivo commented May 21, 2022

I have tested this item ✅ successfully on 94bbd50

Tested successfully in Joomla 4.2.0-alpha3-dev of 21 May in Wampserver 3.2.8 using PHP 8.0.15.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37803.

@alikon
Copy link
Contributor

alikon commented May 21, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37803.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 21, 2022
@roland-d roland-d merged commit bf95455 into joomla:4.2-dev May 21, 2022
@roland-d roland-d deleted the j4/plugins/api-auth/basic branch May 21, 2022 18:18
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 21, 2022
@roland-d
Copy link
Contributor

Thanks everybody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants