-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Convert token API auth plugin to services #37804
[4.2] Convert token API auth plugin to services #37804
Conversation
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
I have tested this item ✅ successfully on 633c2ce This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be identical with #37803
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should here a \
added?
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
I have tested this item ✅ successfully on aa76f6c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804. |
@toivo can you test again as there were mainly code style stuff changed, but better be on the safe side. Thanks! |
I have tested this item ✅ successfully on aa76f6c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804. |
I have tested this item ✅ successfully on aa76f6c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804. |
@laoneo, worked all right with the latest dev version and a new Super User. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804. |
Thanks everybody |
Summary of Changes
Convert token API auth plugin to services.
Testing Instructions
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.