Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Convert token API auth plugin to services #37804

Merged
merged 21 commits into from
May 21, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented May 15, 2022

Summary of Changes

Convert token API auth plugin to services.

Testing Instructions

  • Enable the token API auth plugin
  • Save your user settings so a API token is generated
  • Make an API request with bearer authentication with the generated API token, for example you can use curl or postman

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

laoneo and others added 3 commits May 18, 2022 13:44
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@toivo
Copy link
Contributor

toivo commented May 20, 2022

I have tested this item ✅ successfully on 633c2ce

Tested successfully using Postman with Joomla 4.2.0-alpha3-dev of 20 May in Wampserver 3.2.8 and PHP 8.0.15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804.

Copy link
Contributor

@heelc29 heelc29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be identical with #37803

laoneo and others added 4 commits May 20, 2022 11:03
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
laoneo and others added 3 commits May 20, 2022 11:18
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Copy link
Contributor

@heelc29 heelc29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should here a \ added?

laoneo and others added 3 commits May 20, 2022 13:09
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@heelc29
Copy link
Contributor

heelc29 commented May 20, 2022

I have tested this item ✅ successfully on aa76f6c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804.

@laoneo
Copy link
Member Author

laoneo commented May 20, 2022

@toivo can you test again as there were mainly code style stuff changed, but better be on the safe side. Thanks!

@eeshaanSA
Copy link
Contributor

I have tested this item ✅ successfully on aa76f6c

followed testing instructions and tested successfully. Xampp used. PHP verison: 8.1.6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804.

@toivo
Copy link
Contributor

toivo commented May 21, 2022

I have tested this item ✅ successfully on aa76f6c

Tested successfully in Joomla 4.2.0-alpha3-dev of 20 May.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804.

@toivo
Copy link
Contributor

toivo commented May 21, 2022

@laoneo, worked all right with the latest dev version and a new Super User.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804.

@alikon
Copy link
Contributor

alikon commented May 21, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37804.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 21, 2022
@roland-d roland-d merged commit 6be6d80 into joomla:4.2-dev May 21, 2022
@roland-d roland-d deleted the j4/plugins/api-auth/token branch May 21, 2022 19:01
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 21, 2022
@roland-d
Copy link
Contributor

Thanks everybody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants