[5.2] Removing deprecated access to User object attributes #43268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on eefbe1a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43268. |
rdeutz
approved these changes
Apr 18, 2024
pe7er
reviewed
Apr 23, 2024
pe7er
reviewed
Apr 23, 2024
pe7er
reviewed
Apr 23, 2024
|
Thanks @Hackwar ! |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR removes almost all cases where we are accessing attributes of the user object through the deprecated CMSObject::get() method. All these can be replaced by simply accessing the attribute directly. This change is based on a check with phpstan.
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed