Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2.3] Removing deprecated access to User object attributes #44694

Merged
merged 4 commits into from
Jan 12, 2025

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Jan 7, 2025

Summary of Changes

Re-apply updates from #43268 to new com_users dispatcher (5.2.3 security fix)

Testing Instructions

check https://github.com/joomla/joomla-cms/pull/43268/files#diff-65f728c437890b80fea358c8762fe7d25fecabb5ac63f200ba0409e874db0291

Actual result BEFORE applying this Pull Request

deprecated access to user object guest attribute

Expected result AFTER applying this Pull Request

no deprecated access to user object guest attribute

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@laoneo laoneo self-assigned this Jan 9, 2025
@alikon
Copy link
Contributor

alikon commented Jan 9, 2025

I have tested this item ✅ successfully on ed3a683


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44694.

@laoneo laoneo removed their assignment Jan 9, 2025
@laoneo
Copy link
Member

laoneo commented Jan 9, 2025

I have tested this item ✅ successfully on ed3a683


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44694.

@heelc29 heelc29 mentioned this pull request Jan 9, 2025
4 tasks
@richard67
Copy link
Member

@laoneo Not a good idea to update the branch so the human test counter is reset so when checking in the issue tracker for PRs in state "pending" which have 2 tests, the PR is not found. You should have set RTC before updating the branch, or restored the test results in the issue tracker after the branch update.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44694.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 9, 2025
@pe7er pe7er self-assigned this Jan 12, 2025
@pe7er pe7er enabled auto-merge (squash) January 12, 2025 20:19
@pe7er pe7er added this to the Joomla! 5.2.4 milestone Jan 12, 2025
@pe7er pe7er merged commit e9bbd2a into joomla:5.2-dev Jan 12, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 12, 2025
@pe7er
Copy link
Contributor

pe7er commented Jan 12, 2025

Thanks @heelc29 !

@heelc29 heelc29 deleted the 5.2/com_users/dispatcher branch January 19, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants