MFA and Silent Logins #43790
Closed
MFA and Silent Logins #43790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard67
requested review from
laoneo,
chmst,
rdeutz and
Hackwar
as code owners
|
@leeroy1821 As it's a bug which exists in 5.0 and 5.1 the PR should be made for the 5.1-dev branch. |
Closed
|
@richard67 I had already made a PR for 5.2-dev. Should I close it and open for 5.1-dev? |
@leeroy1821 Yes. I've tried to rebase your 5.2-dev PR to 5.1-dev, but that failed, so I've reverted it. Would be good if you could redo it for 5.1-dev. Thanks in advance. |
4 tasks
|
Third time lucky 🤞 #43796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42308 .
Summary of Changes
Update
\Joomla\Plugin\System\Webauthn\PluginTraits\AjaxHandlerLogin. Fix loading user plugins (broken because maybe a b/c break?). Fix wrong events constructors (missing subject, wrong argument order). Fix triggering events (wrong event name passed).Testing Instructions
Actual result BEFORE applying this Pull Request
Joomla! asks for MFA
Expected result AFTER applying this Pull Request
Joomla does not ask for MFA
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed