Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] MFA and Silent Logins #43796

Merged
merged 6 commits into from
Sep 11, 2024
Merged

[5.2] MFA and Silent Logins #43796

merged 6 commits into from
Sep 11, 2024

Conversation

leeroy1821
Copy link
Contributor

Pull Request for Issue #42308 .

Replaces #43790

Summary of Changes

Update \Joomla\Plugin\System\Webauthn\PluginTraits\AjaxHandlerLogin. Fix loading user plugins (broken because maybe a b/c break?). Fix wrong events constructors (missing subject, wrong argument order). Fix triggering events (wrong event name passed).

Testing Instructions

  • Create user with MFA and passkey login
  • Users, Manage, Options, Multi-factor Authentication, Multi-factor Authentication after silent login => No.
  • Log out
  • Log in with passkey

Actual result BEFORE applying this Pull Request

Joomla! asks for MFA

Expected result AFTER applying this Pull Request

Joomla does not ask for MFA

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@jjnxpct
Copy link

jjnxpct commented Jul 15, 2024

I have tested the code on our test site (J5.1.2) and this fixed the issue. I can login with the passkey, without also needing to use the 2FA token of my security key. Also, the login without the passkey (normal account login + required 2FA token) still works as expected. Excellent! I hope to see this fix in the next Joomla release.

Thanks @leeroy1821

@richard67
Copy link
Member

I have tested the code on our test site (J5.1.2) and this fixed the issue. I can login with the passkey, without also needing to use the 2FA token of my security key. Also, the login without the passkey (normal account login + required 2FA token) still works as expected. Excellent! I hope to see this fix in the next Joomla release.

Thanks @leeroy1821

@jjnxpct Please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43796 and use the blue "Test this" button at the top left corner, select your test result and submit. Otherwise your test will not be counted. A PR needs 2 successful human tests to get accepted.

@jjnxpct
Copy link

jjnxpct commented Jul 30, 2024

I have tested this item ✅ successfully on 7092ecc

I have tested the code on our test site (J5.1.2) and this fixed the issue. I can login with the passkey, without also needing to use the 2FA token of my security key. Also, the login without the passkey (normal account login + required 2FA token) still works as expected. Excellent! I hope to see this fix in the next Joomla release.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43796.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 7092ecc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43796.

@Quy
Copy link
Contributor

Quy commented Jul 30, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43796.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 30, 2024
@Quy Quy changed the title MFA and Silent Logins [5.1] MFA and Silent Logins Aug 11, 2024
@jhrenshaw
Copy link

I have tested this item ✅ successfully on 9365fa0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43796.

@Hackwar Hackwar changed the base branch from 5.1-dev to 5.2-dev August 28, 2024 13:48
@Hackwar Hackwar changed the title [5.1] MFA and Silent Logins [5.2] MFA and Silent Logins Aug 28, 2024
@pe7er pe7er self-assigned this Sep 11, 2024
@Hackwar Hackwar enabled auto-merge (squash) September 11, 2024 21:20
@Hackwar
Copy link
Member

Hackwar commented Sep 11, 2024

Thank you for your contribution @leeroy1821!

@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 11, 2024
@Hackwar Hackwar merged commit 0ef1b1e into joomla:5.2-dev Sep 11, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants