-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] MFA and Silent Logins #43796
[5.2] MFA and Silent Logins #43796
Conversation
I have tested the code on our test site (J5.1.2) and this fixed the issue. I can login with the passkey, without also needing to use the 2FA token of my security key. Also, the login without the passkey (normal account login + required 2FA token) still works as expected. Excellent! I hope to see this fix in the next Joomla release. Thanks @leeroy1821 |
@jjnxpct Please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43796 and use the blue "Test this" button at the top left corner, select your test result and submit. Otherwise your test will not be counted. A PR needs 2 successful human tests to get accepted. |
I have tested this item ✅ successfully on 7092ecc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43796. |
I have tested this item ✅ successfully on 7092ecc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43796. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43796. |
I have tested this item ✅ successfully on 9365fa0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43796. |
Thank you for your contribution @leeroy1821! |
Pull Request for Issue #42308 .
Replaces #43790
Summary of Changes
Update
\Joomla\Plugin\System\Webauthn\PluginTraits\AjaxHandlerLogin
. Fix loading user plugins (broken because maybe a b/c break?). Fix wrong events constructors (missing subject, wrong argument order). Fix triggering events (wrong event name passed).Testing Instructions
Actual result BEFORE applying this Pull Request
Joomla! asks for MFA
Expected result AFTER applying this Pull Request
Joomla does not ask for MFA
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed