-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] [Guided Tours] Arrows do not show properly, especially in dark mode #43825
Conversation
I have tested this item ✅ successfully on da2ff39 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43825. |
1 similar comment
I have tested this item ✅ successfully on da2ff39 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43825. |
My sincere apology, I did not refresh my page and did not see the latest test and RTC label. |
Thanks @obuisard ! |
Summary of Changes
When introducing dark mode, a border was added to the tour popups so that the tours would be more visible in dark mode.
Unfortunately, this 'cuts' the arrows off the popup and no border was added to the arrows themselves so that they are not visible in dark mode.
This is the first attempt in fixing that.
Although this PR fixes the arrows, there is more to be done, particularly that the colors for the tour popups are too dark and barely pop over the content. Check PR#43854.
Testing Instructions
Run the welcome tour in light and dark mode and check that the arrows are showing properly.
Actual result BEFORE applying this Pull Request
A popup in light mode.
The popup border shows over the arrow and the arrow is not of the color of the header background.
A popup in dark mode.
The border cuts off the arrow from the popup and is barely visible.
Expected result AFTER applying this Pull Request
A popup in light mode.
The border is gone and the arrow is of the right color.
A popup in dark mode.
The border no longer cuts off the arrow from the popup and the arrow is more visible.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed