Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] [Guided Tours] Arrows do not show properly, especially in dark mode #43825

Merged
merged 9 commits into from
Aug 9, 2024
Merged

[5.2] [Guided Tours] Arrows do not show properly, especially in dark mode #43825

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
33a25c7
Added border to arrows in all positions and color when bottom
obuisard Jul 22, 2024
d61e112
Changed order of border properties
obuisard Jul 23, 2024
da2ff39
Slightly less dark color for the header
obuisard Jul 23, 2024
a723416
Reverted header color in favor of PR#43854
obuisard Jul 26, 2024
68e832e
Merge branch '5.2-dev' into guided-tours-arrows
pe7er Aug 8, 2024
4d97f1a
Merge branch '5.2-dev' into guided-tours-arrows
QuyTon Aug 8, 2024
76fde65
Merge branch '5.2-dev' into guided-tours-arrows
obuisard Aug 8, 2024
be42542
Merge branch '5.2-dev' into guided-tours-arrows
obuisard Aug 8, 2024
7f887f1
Merge branch '5.2-dev' into guided-tours-arrows
pe7er Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions build/media_source/plg_system_guidedtours/scss/guidedtours.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,44 @@

.shepherd-enabled.shepherd-element[data-popper-placement=bottom] {
transform: translateY(12px);
.shepherd-arrow:before {
border-top: 1px solid var(--border-color-translucent);
border-left: 1px solid var(--border-color-translucent);
}
}

.shepherd-enabled.shepherd-element[data-popper-placement=left] {
transform: translateX(-12px);
.shepherd-arrow:before {
border-top: 1px solid var(--border-color-translucent);
border-right: 1px solid var(--border-color-translucent);
}
}

.shepherd-enabled.shepherd-element[data-popper-placement=top] {
transform: translateY(-12px);
.shepherd-arrow:before {
border-right: 1px solid var(--border-color-translucent);
border-bottom: 1px solid var(--border-color-translucent);
}
}

.shepherd-enabled.shepherd-element[data-popper-placement=right] {
transform: translateX(12px);
.shepherd-arrow:before {
border-bottom: 1px solid var(--border-color-translucent);
border-left: 1px solid var(--border-color-translucent);
}
}

// If the arrow is under the popup, it gets the color of the shadow.
.shepherd-arrow, .shepherd-arrow:before {
z-index: 0;
}

// Missing color setting for the arrow when above the header.
.shepherd-element.shepherd-has-title[data-popper-placement^="bottom"] > .shepherd-arrow:before {
background-color: #e6e6e6 !important;
}

#modGuidedTours-modal a {
Expand Down