-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] close collapse when opening a dropdown #43891
[4.0] close collapse when opening a dropdown #43891
Conversation
I have tested this item ✅ successfully on 3d7b7df This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891. |
@hans2103 Please fix the javascript cs issues reported here https://ci.joomla.org/joomla/joomla-cms/77860/1/33 :
|
@richard67 lint:js issue have been fixed |
build/media_source/templates/administrator/atum/js/template.es6.js
Outdated
Show resolved
Hide resolved
…6.js Co-authored-by: Brian Teeman <brian@teeman.net>
I have tested this item ✅ successfully on c3a925f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891. |
I have tested this item ✅ successfully on c3a925f ( Thanks for this fix, I sometimes have to use my mobile phone and this will help! ) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891. |
Thanks! |
* make sure you click on the button, not any of the children * close collapse when click to open a dropdown * fix lint:js issues * Update build/media_source/templates/administrator/atum/js/template.es6.js Co-authored-by: Brian Teeman <brian@teeman.net> --------- Co-authored-by: Brian Teeman <brian@teeman.net>
* make sure you click on the button, not any of the children * close collapse when click to open a dropdown * fix lint:js issues * Update build/media_source/templates/administrator/atum/js/template.es6.js Co-authored-by: Brian Teeman <brian@teeman.net> --------- Co-authored-by: Brian Teeman <brian@teeman.net>
Given that accordions are also using data-bs-toggle="collapse" it also causes all accordions tabs to close. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43891. |
Pull Request for Issue #28952 .
Summary of Changes
This PR will add some javascript.
When you click on a dropdown element (data-bs-toggle="dropdown") , all open collapse elements (data-bs-toggle="collapse") will close
Testing Instructions
npm ci
to compile both css and jsActual result BEFORE applying this Pull Request
Screen.Recording.2024-08-07.at.11.10.00.mov
Expected result AFTER applying this Pull Request
Screen.Recording.2024-08-07.at.11.44.36.mov
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed