[4.4] Fix the actions menu in the admin isn't working on mobile #44199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
|
It seems that the issue at hand is introduced with my PR for issue #43891, solving overlapping dropdowns. Adding the check as proposed in this PR solves that issue. Good catch @AkameOuO |
|
I have tested this item ✅ successfully on 43c6243 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44199. |
|
@hans2103 Thanks for checking and testing. |
|
I have tested this item ✅ successfully on 43c6243 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44199. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44199. |
|
Thank you |
richard67
added a commit
that referenced
this pull request
Oct 7, 2024
[5.2] Upmerge 2024-10-07: Changes from PR #44199 .
richard67
added a commit
that referenced
this pull request
Oct 8, 2024
[5.3] Upmerge 2024-10-08: - [4.4] Update NPM developer dependencies braces, fill-range, micromatch and rollup #44159 - [4.4] Fix the actions menu in the admin isn't working on mobile #44199 - [5.2][GuidedTours] replace deprecated access of input property #44195 - [5.2] Translation Update #44191 - [5.2] SEF: Don't remove trailingslash on hp in a subdir #44205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44198 .
Summary of Changes
Fix the actions menu in the admin isn't working on mobile
Testing Instructions
Select one or more articles / users from the list. Then click in the top right corner to open the menu and click on 'Actions'.
Actual result BEFORE applying this Pull Request
The whole menu is closed.
Expected result AFTER applying this Pull Request
Open the submenu to give you a choice
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed