[5.2][GuidedTours] replace deprecated access of input property #44195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on b67e9c9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44195. |
|
I have tested this item ✅ successfully on b67e9c9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44195. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44195. |
|
Thank you for your contribution @heelc29 |
richard67
added a commit
that referenced
this pull request
Oct 8, 2024
[5.3] Upmerge 2024-10-08: - [4.4] Update NPM developer dependencies braces, fill-range, micromatch and rollup #44159 - [4.4] Fix the actions menu in the admin isn't working on mobile #44199 - [5.2][GuidedTours] replace deprecated access of input property #44195 - [5.2] Translation Update #44191 - [5.2] SEF: Don't remove trailingslash on hp in a subdir #44205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
#43814 use deprecated code
https://github.com/joomla-framework/application/blob/dd055642fbe8d7b919a6c6c345a0d016b0981e65/src/AbstractWebApplication.php#L229-L238
See also #39029 for information
Testing Instructions
Actual result BEFORE applying this Pull Request
Use of deprecated access to the application's input property
Expected result AFTER applying this Pull Request
Application->getInput() instead of Application->input (no deprecation warning)
Link to documentations
Please select: