Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[5.2] Remove legacy code for filtering state in backend model… #43918

Closed
wants to merge 1 commit into from

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

This reverts (#43230)

Clearly the code is used and cannot simply be removed as was done in the original pr

Testing Instructions

This is for 5.2 only
Clear all session storage, cookies etc
Log in to the admin and go to the system page

Actual result BEFORE applying this Pull Request

Language Overrides - error undefined constant
Update Sites - no results

Expected result AFTER applying this Pull Request

All works as expected

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fontanil
Copy link

Thanks @brianteeman

Tested with Patch tester, the PR works fine for me: Update Sites and Langage Overrides
Sorry I don't remember how to validate my check
Robert

@richard67
Copy link
Member

Sorry I don't remember how to validate my check

@fontanil You go to the PR in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43918 , then use the blue "Test this" button at the top left corner, select your test result and submit.

@fontanil
Copy link

I have tested this item ✅ successfully on a69c80e

Tested successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43918.

@Hackwar
Copy link
Member

Hackwar commented Aug 14, 2024

I am aware of the problem in the overrides and will fix that. Reverting the whole PR is wrong and will not happen.

@brianteeman
Copy link
Contributor Author

brianteeman commented Aug 14, 2024

it is not just the language overrides

I made the PR as a temp measure until someone had the time and was able to investigate the issue with all the components and still allow people to test 5.2

@fgsw
Copy link

fgsw commented Aug 16, 2024

I have tested this item ✅ successfully on a69c80e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43918.

@Hackwar
Copy link
Member

Hackwar commented Aug 16, 2024

#43930 fixes the issues. Closing this one as the other one is a bit more precise.

@Hackwar Hackwar closed this Aug 16, 2024
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the revert branch August 16, 2024 15:55
@fontanil
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants