Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Partial revert of #43230 #43930

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Aug 16, 2024

Summary of Changes

#43230 broke the Language Overrides list view and the list view for updatesites. This PR fixes that again.

Testing Instructions

  1. Install a clean 5.2-dev Joomla installation
  2. Go to the list of language overrides
  3. Go to the list of updatesites

Actual result BEFORE applying this Pull Request

Language overrides throws a hard error, updatesites doesn't show any updatesites.

Expected result AFTER applying this Pull Request

Language overrides works as expected, updatesites shows a list of updatesites.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Aug 16, 2024

I have tested this item ✅ successfully on 7fd9943


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43930.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 7fd9943


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43930.

@Hackwar
Copy link
Member Author

Hackwar commented Aug 16, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43930.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 16, 2024
@pe7er pe7er merged commit ceab5b5 into joomla:5.2-dev Aug 17, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 17, 2024
@pe7er
Copy link
Contributor

pe7er commented Aug 17, 2024

Thanks @Hackwar !

@Hackwar Hackwar deleted the 5.2-models-states branch August 17, 2024 08:16
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants