[5.3] Move to ESM redo of #43779 #44296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
build/media_source/system/js/joomla-core-loader.mjs
file now includes the required css and the relatedbuild/media_source/system/scss/joomla-core-loader.scss
is deletedTesting Instructions
You need Git and NPM to test this
Pull the
5.3-dev
branch and run:npm install
npm run cssversioning
npm run gzip
npm run versioning
joomla-cms
folderPull this PR
gh pr checkout 43781
and run:npm install
npm run cssversioning
npm run gzip
npm run versioning
joomla-cms
folderCompare the two folders. The only difference should be the missing files:
media/system/css/joomla-core-loader.css
,media/system/css/joomla-core-loader.min.css
,media/system/css/joomla-core-loader.min.css.gz
Check the basic backend functionality
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed