Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Move to ESM redo of #43779 #44296

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

  • Move tools and source JS to ESM
  • The build/media_source/system/js/joomla-core-loader.mjs file now includes the required css and the related build/media_source/system/scss/joomla-core-loader.scss is deleted

Testing Instructions

You need Git and NPM to test this

Pull the 5.3-dev branch and run:

  • npm install
  • npm run cssversioning
  • npm run gzip
  • npm run versioning
  • Store the media folder somewhere outside of the joomla-cms folder

Pull this PR gh pr checkout 43781 and run:

  • npm install
  • npm run cssversioning
  • npm run gzip
  • npm run versioning
  • Store the media folder somewhere outside of the joomla-cms folder

Compare the two folders. The only difference should be the missing files: media/system/css/joomla-core-loader.css, media/system/css/joomla-core-loader.min.css, media/system/css/joomla-core-loader.min.css.gz

Check the basic backend functionality

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@bembelimen
Copy link
Contributor

I have tested this item ✅ successfully on 5800f30

Looks good!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44296.

@LadySolveig LadySolveig merged commit 8deec03 into joomla:5.3-dev Oct 17, 2024
3 of 4 checks passed
@LadySolveig
Copy link
Contributor

Thank you @dgrammatiko 💚 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants