[5.3] Update deleted files in script.php for the upcoming 5.3.0-alpha1 #44450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgrammatiko As you have removed the |
|
It's safe to remove those files as they where used exclusively during the bundling, they won't affect the web component as it already has those encapsulated (either before or after the PR #44296). |
|
@dgrammatiko Thanks for the quick reply. |
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) updates the list of files to be deleted on update in script.php to the latest changes in the 5.3-dev branch.
Currently there are only files from PR #44296 .
Testing Instructions
Code review and check the description of PR #44296 , or compare a recent 5.3-dev nightly build with a 5.2-dev nightly build and check for files which exist only in the 5.2-dev but not in 5.3-dev build.
Actual result BEFORE applying this Pull Request
The files added by this PR to the list are still there after an update from 5.2.x to 5.3-dev.
Expected result AFTER applying this Pull Request
The files added by this PR to the list are deleted after an update from 5.2.x to 5.3-dev.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed