Add Event onAfterRenderModule

[ced1870]

Allows the plugins to catch the module object (content and params) before it renders into the page. This is very useful for design purposes

[brianteeman]

It would be useful if you could provide an example of how to test this functionality

[ced1870]

Hi Brian,
Here an example of use :
1/ create a sytem plugin
2/ write
function onAfterRenderModule($module, $attribs) {
$module->content = '

' . $module->content . '

';
}
3/ this will render a div around the module that can be used to add some styles or link to some JS to make it float

This is a basic example, where of course you would need in your plugin to test if you are in admin or front, make some additional condition to target the needed module and have the best conditions to do it (like any good developer would do in any plugin ;) )

Hope that this is clear and that you will think about implementing it.
Please let me know
Regards
CEd

[Fedik]

personally, I think that for such cases the ModuleChrome https://docs.joomla.org/Module_chrome cover all needs here

[ced1870]

@Fedik : how to you catch and render the module from a plugin ? the module Chrome covers all needs if you are inside a template only
I use the JModuleHelper class in many cases and sometimes it needs to change the module content

[Bakual]

I tend to agree with @Fedik here, at least for the use case you mentioned. The module chrome is exactly meant to provide design around a module content. Like adding a div around the content.
If you need to alter the output of the module itself, template overrides are the way to go, assuming the module is coded right.

I don't see yet the usecase where you would need a plugin event, but feel free to make an example.

[ced1870]

I have made a little example above :)

Imagine that you want to develop a plugin that will add some options into a module (any module in this case), then using the plugin you can check the options and do some work. In my case I add a button to make the module sticky.
If the user click the button in the module options, the plugin alter the module code before rendering in the page to add the sticky class.

this is a simple example, now if you know of to do all this using Module Chrome, let me know :)
I don't see where is the problem to add this event, is there anyone ?

[Bakual]

Thanks for the example. It makes more sense now.

[brianteeman]

Are these three issues related #8693 #8296 #3105

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8693.}

[ghost]

Is pretty much a carbon copy of: #8296

[ced1870]

I have not seen the other requests that are similar. For me, no matter who's name is for the pull request, the only thing that is important to me is that this trigger is added to allow more customization and user interaction. Thank you

[ced1870]

Hi
Is there any news about the implementation of this trigger ?
Thank you
CEd

[Bakual]

Without any human tests, it will usually go nowhere.

[ced1870]

Ok so please tell me wo needs to test and how.

[Bakual]

Anyone (beside you as it's your own PR and we assume you tested it) can test this PR by using the Joomla patchtester (http://joom.la/patchtester).
They should then log their results in https://issues.joomla.org/tracker/joomla-cms/8693

Usually we require two good tests for anything to be merged.

Since this introduces a new feature/API point, it can go into Joomla 3.6.0 earliest (3.5.0 is feature locked already as it is in beta).

[ced1870]

ok thank you for the informations

[andrepereiradasilva]

The process for testers is described here https://docs.joomla.org/Testing_Joomla!_patches

Normally it helps getting testing if you have a clear "How to test" or "Testing instructions" block in the PR description with clear and simple instructions on how to test (and screenshots if needed).

Example: #8350

[ghost]

But this PR can get closed as it is a duplicate of #8296