Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: Update - show current version of extension #8350

Closed
wants to merge 3 commits into from
Closed

Extensions: Update - show current version of extension #8350

wants to merge 3 commits into from

Conversation

pe7er
Copy link
Contributor

@pe7er pe7er commented Nov 9, 2015

This PR adds to Extensions: Update the current version of an extension. The current list of extensions that could be updated to a newer version only shows the new version number.

This feature was requested by wkone in Joomla forum http://forum.joomla.org/viewtopic.php?f=708&t=898474. I think that showing the current and new version gives an administrator more information about possible issues: If the extensions uses semantic versioning then 2.1 to 2.2 is a minor update with little issues. An update from 2.9 to 3.1 might give somewhat more issues.

Testing Instructions

I had to test this feature on a Joomla 3.4.5 website because I was not able to use the "Extension: Update" funtion in Joomla 3.5Beta1. After installing some old versions of some extensions in 3.5Beta1 I did not get the list of updates for those extensions. Probably because those extensions do not have new versions for 3.5Beta1...

Edit: Workaround to test this patch on Joomla 3.5Beta1:
manually edit libraries/cms/version/version.php and temporary change the constant for Release & Development level:
const RELEASE = '3.4.5';
const DEV_LEVEL = 'stable';
With these values Joomla will find new extension updates for old 3rd party extensions.

Don't forget to change it back to the original values after testing this patch. Original values:
const RELEASE = '3.5';
const DEV_LEVEL = '0-beta';

Before the PR

I've installed 3 older versions of extensions that use Joomla's update functionality.
Extensions: Update (via Extensions > Manage > Update) shows that there are 3 updates that can be installed. It shows the version of the extension that will be installed but not the current version

com_installer-update-current-version-before

After the PR

After installing this PR the Extensions: Update (via Extensions > Manage > Update) shows Current version and Version (that will be installed)

com_installer-update-current-version-after

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Nov 9, 2015
@pe7er
Copy link
Contributor Author

pe7er commented Nov 9, 2015

I've changed the label "Version" to "Update to Version" to make it more clear that its the number of the new version.

@waader
Copy link
Contributor

waader commented Nov 9, 2015

I have tested this item ✅ successfully on b06292c

👍


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

@infograf768
Copy link
Member

Nice.
I could test easily on staging for some extensions who do not specify the minor J version.
screen shot 2015-11-09 at 17 51 28

@infograf768
Copy link
Member

I have tested this item ✅ successfully on b06292c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

@zero-24
Copy link
Contributor

zero-24 commented Nov 9, 2015

@roland-d please decide if this can go into 3.5

RTC Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 9, 2015
@roland-d roland-d added this to the Joomla! 3.6.0 milestone Nov 10, 2015
@brianteeman
Copy link
Contributor

I think "Available Version" is better?
"Update to" describes an action not some information


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @infograf768, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

@pe7er
Copy link
Contributor Author

pe7er commented Nov 11, 2015

Thanks for testing @waader & @infograf768 !

Good point @brianteeman!
I've just changed the language string to "Available Version"

@brianteeman
Copy link
Contributor

Thanks for doing that @pe7er


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on d8deaed

Works as intended thanks

As a small visual improvement if you remove the 10% on the th then you wont get the ugly/inconsistent wrapping on the titles


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

@pjwiseman
Copy link
Contributor

I have tested this item ✅ successfully on d8deaed

Nice feature.

Whilst removing the 10% width on the version fields does avoid the inconsistent title wrappings, it does that at a cost of a rather wide field on a wide display. I'd swing either way. Hence, it's a successful test.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

@@ -93,6 +96,9 @@
<?php echo JText::_('COM_INSTALLER_TYPE_' . $item->type) ?>
</td>
<td>
<?php echo json_decode($item->manifest_cache, true)['version']; ?>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If for some reason the manifest_cache is empty, then this will cause an error.
See for more stable implementation: #8768

@pe7er
Copy link
Contributor Author

pe7er commented Jan 5, 2016

Thanks @nonumber !
I'll try to correct the patch with your corrected code soon...

@wilsonge
Copy link
Contributor

I'm going to close this in favour of the code proposed by @nonumber in #8768

@wilsonge wilsonge closed this Jan 17, 2016
@wilsonge wilsonge removed the RTC This Pull Request is Ready To Commit label Jan 17, 2016
@wilsonge wilsonge removed this from the Joomla! 3.6.0 milestone Jan 17, 2016
@pe7er pe7er deleted the com_installer-update-currentversion branch September 25, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants