Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds current version to Extension Update Manager #8768

Closed
wants to merge 4 commits into from
Closed

Adds current version to Extension Update Manager #8768

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 22, 2015

It is often useful to know what version of an extension you have installed before updating it to the latest version.
Currently the Extension Update Manager does not provide this information, making you to have to go search for it.
This PR fixes this.

Before:
before

After:
after

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Dec 22, 2015
@ghost ghost changed the title Adds current version to updates view Adds current version to Extension Update Manager Dec 22, 2015
@brianteeman
Copy link
Contributor

Please see #8350

@andrepereiradasilva
Copy link
Contributor

Yes, already in #8350
But from a usability point i think @nonumber background colors are helpful and would be a nice addon to #8350

@810
Copy link
Contributor

810 commented Dec 24, 2015

Maybe also remove install type & folder & url details for UX

@brianteeman
Copy link
Contributor

The url is important to ensure that you are not being tricked to go to an unauthorised domain

@810
Copy link
Contributor

810 commented Dec 24, 2015

does the "normal" user know that url. I believe its not to be needed there.

@brianteeman
Copy link
Contributor

If the url for a kunena update was hackme.now they would want to know.

It is trivial to make that change in the current architecture so let's at
least make it visible.
On 24 Dec 2015 10:46 am, "Jelle Kok" notifications@github.com wrote:

does the "normal" user know that url. I believe its not to be needed there.


Reply to this email directly or view it on GitHub
#8768 (comment).

@810
Copy link
Contributor

810 commented Dec 24, 2015

maybe a check with the jed. if ok see tick, else orange question mark. with tooltip with the url.

@brianteeman
Copy link
Contributor

Feel free to contribute that code. Until it exists we must display the url

On 24 December 2015 at 12:41, Jelle Kok notifications@github.com wrote:

maybe a check with the jed. if ok see tick, else orange question mark.
with tooltip with the url.


Reply to this email directly or view it on GitHub
#8768 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@810
Copy link
Contributor

810 commented Jan 17, 2016

I have tested this item ✅ successfully on 6ccde61


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8768.

@brianteeman
Copy link
Contributor

RTC - thanks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8768.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 17, 2016
@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Jan 26, 2016
@wilsonge
Copy link
Contributor

Merged - thanks everyone!

@wilsonge wilsonge closed this in 57c8281 Jan 26, 2016
@ghost ghost deleted the patch-2 branch January 28, 2016 07:35
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants