-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to terser, sets foundation for typescript migration #155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 183 189 +6
Branches 52 63 +11
=====================================
+ Hits 183 189 +6
Continue to review full report at Codecov.
|
Looks like you lost the references to the original You should use Looks promising - though it's a bit hard to review changes without a diff :-) |
@mindplay-dk Thank you for checking. So far I tried using However, nothing seems to provide a diff in github. The history on individual files, is now correctly preserved (with I will try more tomorrow to get github show correct diff, but their algorithm appears to have few hardcoded limits (see diffcore-renam.c Funny enough, when I navigate individual commits, I am able to see correct diff. Check this for example, 88e4487 |
Yeah, huh. Not your bad then. Probably should file a bug report with GitHub? Now that I can see the diff - I see you've added semi-colons to the entire codebase; I don't personally have any strong feelings one way or the other, but that's a style-change, unrelated to the changes you're proposing, and it's making the diff extremely noisy and hard to read. A code style change probably belongs in a separate proposal. Which I'm fairly sure @jorgebucaran would reject 😉 |
Also, this is how generated d.ts file looks so far
Next up, figure how to correctly type |
Likely because the files are now similar enough to look like the same file :-) |
Lots of work to do in terms of hinting params and return-types, but this looks like a good start towards the goal of using more ES6 features and porting to Typescript :-) If I may, I'd like to suggest merging this to a separate branch (e.g. |
@osdevisnot I agree, migrating to terser and migrating to TypeScript are different things. Could this PR only take care of the first? |
Yeah, the switch to terser makes sense now - while the TypeScript switch is probably a much longer process. A separate PR for the switch to terser would make a lot of sense. |
@mindplay-dk @jorgebucaran makes sense. I will close this PR and create 2 separate ones for separation of concerns. |
What this PR does
Future Work
Todo before merging this PR
Please note, this initial PR attempts to achieve above features with least possible changes to src. Main objective for this PR is to collect feedback from community.
Thoughts / Opinions ?