-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript foundation #158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 183 196 +13
Branches 52 64 +12
=====================================
+ Hits 183 196 +13
Continue to review full report at Codecov.
|
@jorgebucaran @mindplay-dk this is continuation of TS porting efforts that were being discussed in #155. Currently this is on a branch in my-fork and the PR is against master of this repo. |
*/ | ||
export var h = function( | ||
name: string | Function, | ||
props?: any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mindplay-dk existing definition for h are open to Props being a type. This works ok when declaring TS definitions separately. Any pointers on how I can achieve that using TS definitions in file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only difference as far as I can figure, is the h
function will have a body - other than that, you should be able to just copy and paste from the original .d.ts
?
You'll want to exclude the .d.ts
from the build (as you do already) and move to emitting a generated .d.ts
instead - once you have all the type declarations moved over, the emitted .d.ts
should be very close to the hand-written one we have now.
(I'm not sure if that's what you were asking?)
The codebase has changed quite a bit. If this is going to happen, we might as well start from scratch. |
Tasks Completed:
ts-jest
overjest
and babelrollup.config.js
over commands in scripts section ofpackage.json
main
,module
andtypyings
fields inpackage.json
to distpackage.json
.d.ts
file as this will now be auto generated.Tasks Pending:
strict
mode