This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Correctly update child-offsets in GrowableUnion
#1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
changed the title
GrowableUnion
Codecov ReportBase: 83.28% // Head: 83.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1360 +/- ##
==========================================
+ Coverage 83.28% 83.37% +0.08%
==========================================
Files 371 371
Lines 40239 40277 +38
==========================================
+ Hits 33515 33582 +67
+ Misses 6724 6695 -29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Jan 15, 2023
jorgecarleitao
approved these changes
Jan 16, 2023
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 29, 2023
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves: #1359
As mentioned in the ticket, union offsets weren't being correctly updated to reflect positions in the new child fields. This adds a new method to the
Growableinterface:len(). I believe I've got the right interpretation for the different growable implementations but would very much appreciate a sanity check there.