Arrow support for image_file and image-related bug-fixes #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
force-pushed
the
jleibs/arrow_image_file
branch
from
a0b0b00
to
22911ab
Compare
jleibs
changed the title
jondo2010
reviewed
Jan 16, 2023
Comment on lines
+96
to
+100
| arrow2 = { workspace = true, features = [ | ||
| "io_ipc", | ||
| "io_print", | ||
| "compute_concatenate", | ||
| ] } |
There was a problem hiding this comment.
It's nice having the concatenation test in there given what a problem it caused for images.
jondo2010
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds JPEG encoded data to the tensor storage and uses bridge to do arrow logging on the image_file path.
Will move this to pure python once @jondo2010 lands the SDK updates for logging images from python.
This finally makes the objectron demo work end-to-end:
This unsurfaced a bug where we start getting bad data once we split the bucket:
#759, resulting in two additional upstream PRs:GrowableUnionjorgecarleitao/arrow2#1360Checklist
CHANGELOG.md(if this is a big enough change to warrant it)