-
Notifications
You must be signed in to change notification settings - Fork 223
Added support for MONTH_DAY_NANO
interval type
#268
Conversation
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 81.30% 81.05% -0.26%
==========================================
Files 326 326
Lines 21000 21103 +103
==========================================
+ Hits 17075 17105 +30
- Misses 3925 3998 +73
Continue to review full report at Codecov.
|
5c3e6f7
to
930cb6d
Compare
✅ Integration tests against emkornfield's branch (with the changes being PRed to apache/arrow). This is ready and just waits the PR to land on apache/arrow. fyi @emkornfield, since this further evidence that things look great. |
Thanks! Curious if you have any thoughts on Rust CI integration failures I'm seeing on the PR |
879480b
to
94f3910
Compare
94f3910
to
88ff265
Compare
eda9c6e
to
f017e08
Compare
Integration tests are passing against apache/master with the patch that unskips most of the cases including |
4d7d3ee
to
270b4bd
Compare
270b4bd
to
1ce52bc
Compare
MONTH_DAY_NANO
interval type
The changes are rather simple since the physical type can be represented as
months_days_ns(i32, i32, i64)
, which fulfills all the conditions of the traitNativeType
.It does not support FFI since FFI has not been spec-ed yet.
Closes #360