Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for MONTH_DAY_NANO interval type #268

Merged
merged 3 commits into from
Aug 31, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Aug 10, 2021

The changes are rather simple since the physical type can be represented as months_days_ns(i32, i32, i64), which fulfills all the conditions of the trait NativeType.

It does not support FFI since FFI has not been spec-ed yet.

Closes #360

@jorgecarleitao jorgecarleitao changed the title Added support for MONTH_DAY_NANO intervals Added support for MONTH_DAY_NANO interval type Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #268 (1ce52bc) into main (2f1d8fe) will decrease coverage by 0.25%.
The diff coverage is 30.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   81.30%   81.05%   -0.26%     
==========================================
  Files         326      326              
  Lines       21000    21103     +103     
==========================================
+ Hits        17075    17105      +30     
- Misses       3925     3998      +73     
Impacted Files Coverage Δ
src/array/equal/mod.rs 87.77% <ø> (ø)
src/array/mod.rs 58.97% <ø> (ø)
src/array/primitive/mod.rs 77.27% <ø> (ø)
src/compute/aggregate/memory.rs 40.00% <ø> (ø)
src/compute/filter.rs 75.37% <ø> (ø)
src/compute/take/mod.rs 92.68% <ø> (ø)
src/ffi/array.rs 68.75% <ø> (ø)
src/ffi/schema.rs 57.91% <ø> (ø)
src/io/ipc/convert.rs 94.98% <0.00%> (-0.40%) ⬇️
src/io/ipc/read/deserialize.rs 94.64% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1d8fe...1ce52bc. Read the comment docs.

@jorgecarleitao jorgecarleitao marked this pull request as draft August 11, 2021 07:10
@jorgecarleitao jorgecarleitao force-pushed the month_day_nano branch 6 times, most recently from 5c3e6f7 to 930cb6d Compare August 12, 2021 07:40
@jorgecarleitao jorgecarleitao marked this pull request as ready for review August 12, 2021 07:44
@jorgecarleitao
Copy link
Owner Author

✅ Integration tests against emkornfield's branch (with the changes being PRed to apache/arrow).

This is ready and just waits the PR to land on apache/arrow.

fyi @emkornfield, since this further evidence that things look great.

@emkornfield
Copy link

Thanks! Curious if you have any thoughts on Rust CI integration failures I'm seeing on the PR

src/types/mod.rs Outdated Show resolved Hide resolved
@jorgecarleitao
Copy link
Owner Author

Integration tests are passing against apache/master with the patch that unskips most of the cases including generate_month_day_nano_interval_case 🎉

@jorgecarleitao jorgecarleitao changed the title Added support for MONTH_DAY_NANO interval type Added support for MONTH_DAY_NANO interval type Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MonthDayNano added to enum IntervalUnit
2 participants