Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for non-ordered projections to IPC reading #961

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

jorgecarleitao
Copy link
Owner

This allows passing projection: Some(vec![2, 1]) to the IPC readers. Beforehand this would panic / not supported

Related to pola-rs/polars#1761

@jorgecarleitao jorgecarleitao added the feature A new feature label Apr 22, 2022
@jorgecarleitao jorgecarleitao changed the title Added non-ordered projections to IPC reading Added support for non-ordered projections to IPC reading Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #961 (ce45bde) into main (04605a2) will increase coverage by 0.06%.
The diff coverage is 84.37%.

@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
+ Coverage   71.03%   71.09%   +0.06%     
==========================================
  Files         351      351              
  Lines       19446    19456      +10     
==========================================
+ Hits        13814    13833      +19     
+ Misses       5632     5623       -9     
Impacted Files Coverage Δ
src/io/ipc/read/file_async.rs 60.62% <44.44%> (+2.03%) ⬆️
src/io/ipc/read/common.rs 82.94% <100.00%> (+2.41%) ⬆️
src/io/ipc/read/reader.rs 75.55% <100.00%> (+2.69%) ⬆️
src/compute/arithmetics/time.rs 26.60% <0.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04605a2...ce45bde. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant