Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ipc column order #3706

Merged
merged 1 commit into from
Jun 15, 2022
Merged

fix ipc column order #3706

merged 1 commit into from
Jun 15, 2022

Conversation

ritchie46
Copy link
Member

fixes #3704

@github-actions github-actions bot added the rust Related to Rust Polars label Jun 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #3706 (67b1c3d) into master (e177a75) will decrease coverage by 0.01%.
The diff coverage is 53.12%.

@@            Coverage Diff             @@
##           master    #3706      +/-   ##
==========================================
- Coverage   61.80%   61.79%   -0.02%     
==========================================
  Files         436      436              
  Lines       72468    72527      +59     
==========================================
+ Hits        44790    44815      +25     
- Misses      27678    27712      +34     
Impacted Files Coverage Δ
polars/polars-io/src/ipc.rs 48.58% <53.12%> (+0.59%) ⬆️
...lars/polars-core/src/chunked_array/builder/list.rs 61.17% <0.00%> (-1.40%) ⬇️
...ars/polars-core/src/series/implementations/utf8.rs 68.16% <0.00%> (-1.13%) ⬇️
polars/polars-core/src/series/from.rs 68.43% <0.00%> (-0.63%) ⬇️
...lars/polars-core/src/chunked_array/ops/take/mod.rs 51.16% <0.00%> (-0.34%) ⬇️
polars/polars-core/src/datatypes.rs 48.14% <0.00%> (-0.19%) ⬇️
polars/polars-core/src/series/mod.rs 53.16% <0.00%> (-0.16%) ⬇️
polars/polars-core/src/frame/hash_join/mod.rs 41.87% <0.00%> (-0.10%) ⬇️
polars/polars-core/src/series/arithmetic.rs 35.77% <0.00%> (+0.20%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e177a75...67b1c3d. Read the comment docs.

@ritchie46 ritchie46 merged commit 55acdb6 into master Jun 15, 2022
@ritchie46 ritchie46 deleted the fix_ipc_col_order branch June 15, 2022 12:22
@ghuls
Copy link
Collaborator

ghuls commented Jun 15, 2022

@ritchie46 Was this not supposed to be handled by arrow2? jorgecarleitao/arrow2#961

@ritchie46
Copy link
Member Author

Yeah, but currently it's just sorted upstream so the order differs. See: jorgecarleitao/arrow2#1074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column order/data scrambled when reading back from ipc file (regression?)
3 participants