Skip to content

Commit

Permalink
build: update nodejs rules (angular#14622)
Browse files Browse the repository at this point in the history
Updates to the latest version of the NodeJS rules that includes bazel-contrib/rules_nodejs@c40ceb9
  • Loading branch information
devversion authored and josephperrott committed Jan 14, 2019
1 parent fdc4075 commit 7747217
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
9 changes: 3 additions & 6 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,8 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
# Add NodeJS rules (explicitly used for sass bundle rules)
http_archive(
name = "build_bazel_rules_nodejs",
# TODO(devversion): temporarily depend on a specific commit because we want to make sure that
# our CI is not flaky until there is a new version of the NodeJS rules. See commit:
# https://github.com/bazelbuild/rules_nodejs/commit/c40ceb960af4213164d4299d8fbc8220ebdd727f
url = "https://github.com/bazelbuild/rules_nodejs/archive/c40ceb960af4213164d4299d8fbc8220ebdd727f.zip",
strip_prefix = "rules_nodejs-c40ceb960af4213164d4299d8fbc8220ebdd727f",
url = "https://github.com/bazelbuild/rules_nodejs/archive/0.16.4.zip",
strip_prefix = "rules_nodejs-0.16.4",
)

# Add TypeScript rules
Expand Down Expand Up @@ -83,7 +80,7 @@ check_bazel_version("0.18.0")

node_repositories(
# For deterministic builds, specify explicit NodeJS and Yarn versions.
node_version = "10.10.0",
node_version = "10.13.0",
# Use latest yarn version to support integrity field (added in yarn 1.10)
yarn_version = "1.12.1",
)
Expand Down
1 change: 0 additions & 1 deletion tools/release/publish-release.ts
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ class PublishReleaseTask extends BaseReleaseTask {

/** Creates a specified tag and pushes it to the remote repository */
private createAndPushReleaseTag(tagName: string, releaseNotes: string) {
// TODO(devversion): find a way to extract the changelog part just for this version.
if (!this.git.createTag('HEAD', tagName, releaseNotes)) {
console.error(red(` ✘ Could not create the "${tagName}" tag.`));
console.error(red(` Please make sure there is no existing tag with the same name.`));
Expand Down

0 comments on commit 7747217

Please sign in to comment.