Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update nodejs rules #14622

Merged
merged 1 commit into from
Jan 9, 2019
Merged

build: update nodejs rules #14622

merged 1 commit into from
Jan 9, 2019

Conversation

devversion
Copy link
Member

Updates to the latest version of the NodeJS rules that includes bazel-contrib/rules_nodejs@c40ceb9

@devversion
build: update nodejs rules
6d55cbb 
Updates to the latest version of the NodeJS rules that includes bazel-contrib/rules_nodejs@c40ceb9
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 24, 2018
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 24, 2018
@devversion devversion mentioned this pull request Dec 28, 2018
Merged
jelbourn
jelbourn approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 9, 2019
@andrewseguin andrewseguin merged commit 0d7258b into angular:master Jan 9, 2019
andrewseguin pushed a commit that referenced this pull request Jan 10, 2019
@devversion @andrewseguin
build: update nodejs rules (#14622)
68d98c3 
Updates to the latest version of the NodeJS rules that includes bazel-contrib/rules_nodejs@c40ceb9
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@devversion @josephperrott
build: update nodejs rules (angular#14622)
7747217 
Updates to the latest version of the NodeJS rules that includes bazel-contrib/rules_nodejs@c40ceb9
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @andrewseguin