-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tclass of xts changes in various functions #322
Comments
Thanks for the report! I would be great if you could come up with a regression test for each instance you've identified where |
These tests guarantee that application of a relational operator on an xts time series does not change its time class (tclass). See joshuaulrich#322.
Thanks for the nice package! I created some tests, as you can see in my pull request. |
@TomAndrews, we were so focused on adding tests for the @philaris thanks for the kind words and the contribution! |
Ensure relational operators on an xts with a POSIXct index does not change the 'tclass' attribute. See #322.
The result of reclass() always returned an object with a POSIXct tclass, even if 'match.to' did not have a POSIXct tclass. The test, test.reclass_preserves_match.to_tclass(), fails if the changes to xts.R are not applied. See #322.
I fixed the specific cases mentioned in this issue. Please open a new issue if you find more cases that I missed. Thanks for the report @TomAndrews, and the tests @philaris! |
Description
I've come across a few cases in xts 0.12 where tclass gets changed:
and
This is a regression of #249 in 0.12
I think there are a few places where
.indexClass
was passed into the.xts
constructor before andtclass
needs adding in its place.Expected behavior
tclass
should not be adjustedSession Info
The text was updated successfully, but these errors were encountered: