Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests for relational operators tclass #323

Merged
merged 1 commit into from
Apr 4, 2020
Merged

tests for relational operators tclass #323

merged 1 commit into from
Apr 4, 2020

Conversation

philaris
Copy link
Contributor

These tests guarantee that application of a relational operator on an xts time series does not change its time class (tclass).

See #322.

@philaris
tests for relational operators tclass
8411426 
These tests guarantee that application of a relational operator on an xts
time series does not change its time class (tclass).

See joshuaulrich#322.
@TomAndrews
Copy link
Contributor

Thanks for doing this!

The other place I found that's broken is here:

xts/R/xts.R

Line 214 in 96b4798

if(!is.xts(x)) x <- .xts(coredata(x),.index(match.to),tzone=tzone(match.to))

Reclass should preserve the tclass of the thing that it's matching to.

joshuaulrich added a commit that referenced this pull request Apr 4, 2020
@joshuaulrich
Combine files with Ops tests
4a3da28 
Move @philaris' tests into the main Ops.xts test file.

See #323.
@joshuaulrich joshuaulrich merged commit 8411426 into joshuaulrich:master Apr 4, 2020
@joshuaulrich joshuaulrich added this to the 0.12-1 milestone Aug 2, 2020
@joshuaulrich joshuaulrich linked an issue Aug 2, 2020 that may be closed by this pull request
tclass of xts changes in various functions #322
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.

tclass of xts changes in various functions
3 participants
@philaris @TomAndrews @joshuaulrich