Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable testing with python 3.6 #262

Merged
merged 1 commit into from
May 16, 2017
Merged

Conversation

purificant
Copy link
Contributor

@purificant purificant commented May 13, 2017

Enable running tests against python 3.6 in Travis

@coveralls
Copy link

coveralls commented May 13, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b737646 on purificant:add_py36_env into 908ee84 on jpadilla:master.

sources:
- deadsnakes
packages:
- python3.5 python3.5-dev
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this addons section required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jpadilla, thanks for taking a look at the PR.

This section installs python3.5 so that both 3.5 and 3.6 interpreters are available in the base test image during Travis run.
"python3.5" is needed to run tests, "python3.5-dev" is needed for crypto dependencies.

Without this section you get an error ERROR: InterpreterNotFound: python3.5

It appears to be an issue with travis base images as described here: travis-ci/travis-ci#4794, the solution also comes from discussions in that thread, I've been iterating on it here: https://travis-ci.org/purificant/pyjwt/builds

Once the issue is resolved upstream we can remove this section.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@purificant great, thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants