Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable testing with python 3.6 #262

Merged
merged 1 commit into from
May 16, 2017
Merged

enable testing with python 3.6 #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
language: python
python:
- "3.5"
- "3.6"
addons:
apt:
sources:
- deadsnakes
packages:
- python3.5 python3.5-dev
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this addons section required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jpadilla, thanks for taking a look at the PR.

This section installs python3.5 so that both 3.5 and 3.6 interpreters are available in the base test image during Travis run.
"python3.5" is needed to run tests, "python3.5-dev" is needed for crypto dependencies.

Without this section you get an error ERROR: InterpreterNotFound: python3.5

It appears to be an issue with travis base images as described here: travis-ci/travis-ci#4794, the solution also comes from discussions in that thread, I've been iterating on it here: https://travis-ci.org/purificant/pyjwt/builds

Once the issue is resolved upstream we can remove this section.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@purificant great, thanks for that!

sudo: false
env:
- TOXENV=flake8
Expand All @@ -9,10 +15,13 @@ env:
- TOXENV=py33-crypto
- TOXENV=py34-crypto
- TOXENV=py35-crypto
- TOXENV=py36-crypto
- TOXENV=py34-nocrypto
- TOXENV=py35-nocrypto
- TOXENV=py36-nocrypto
- TOXENV=py27-nocrypto
- TOXENV=py35-contrib_crypto
- TOXENV=py36-contrib_crypto
- TOXENV=py27-contrib_crypto
install:
- pip install -U pip
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def get_version(package):
'Programming Language :: Python :: 3.3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Topic :: Utilities',
],
test_suite='tests',
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py{26,27,33,34,35}-crypto, py{27,35}-contrib_crypto, py{27,35}-nocrypto, flake8
envlist = py{26,27,33,34,35,36}-crypto, py{27,35,36}-contrib_crypto, py{27,35,36}-nocrypto, flake8

[testenv]
commands =
Expand Down