Merge pull request nasa#584 from skliper/fix335-shell-unsigned-bug

Fix nasa#335: Shell unsigned pkt length bug
jphickey · Apr 21, 2020 · 8ed578e · 8ed578e
2 parents 0cd9f5e + 627a969
commit 8ed578e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/fsw/cfe-core/src/es/cfe_es_shell.c b/fsw/cfe-core/src/es/cfe_es_shell.c
@@ -170,7 +170,7 @@ int32 CFE_ES_ShellOutputCommand(const char * CmdString, const char *Filename)
                 /* start processing the chunks. We want to have one packet left so we are sure this for loop
                 * won't run over */
 
-                for (CurrFilePtr=0; CurrFilePtr < (FileSize - CFE_MISSION_ES_MAX_SHELL_PKT); CurrFilePtr += CFE_MISSION_ES_MAX_SHELL_PKT)
+                for (CurrFilePtr=0; (CurrFilePtr + CFE_MISSION_ES_MAX_SHELL_PKT) < FileSize ; CurrFilePtr += CFE_MISSION_ES_MAX_SHELL_PKT)
                 {
                     OS_read(fd, CFE_ES_TaskData.ShellPacket.Payload.ShellOutput, CFE_MISSION_ES_MAX_SHELL_PKT);