Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES Reports version 5.0.0 in HK telemetry, when built off a development branch #584

Closed
astrogeco opened this issue Aug 31, 2020 · 0 comments · Fixed by #585 or #600
Closed

ES Reports version 5.0.0 in HK telemetry, when built off a development branch #584

astrogeco opened this issue Aug 31, 2020 · 0 comments · Fixed by #585 or #600
Labels
bug
Milestone
Caelum

Comments

@astrogeco
Copy link
Contributor

Describe the bug
Misidentifies version

To Reproduce
Look at version in ES housekeeping packet.

Expected behavior
System should report a consistent version number at startup, from noops, and in tlm. Could go back to the old way where development versions all report a revision of 99.

Code snips
https://github.com/nasa/cFE/blob/a148b97511de3f45f6677c1a3a0b17197f867e28/fsw/cfe-core/src/es/cfe_es_task.c#L333-L340

System observed on:

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle.

Additional context
Got out of sync with new versioning scheme

Reporter Info
Jacob Hageman - NASA/GSFC
@astrogeco astrogeco added the bug label Aug 31, 2020
astrogeco added a commit to astrogeco/osal that referenced this issue Aug 31, 2020
@astrogeco
Fix nasa#584, Set Revision to 99 for development build
7e669a3 
The version number macros major, minor, and revision, are used in the HK telemetry which can lead to confusion.
@astrogeco astrogeco mentioned this issue Sep 1, 2020
Merged
@skliper skliper added this to the 6.0.0 milestone Sep 1, 2020
astrogeco added a commit to astrogeco/osal that referenced this issue Sep 1, 2020
@astrogeco
Fix nasa#584, Set Revision to 99 for development build
f7f39f1 
The version number macros major, minor, and revision, are used in the HK telemetry which can lead to confusion.
yammajamma added a commit that referenced this issue Sep 17, 2020
@yammajamma
Merge pull request #585 from astrogeco/584-fix-version-es-hk
6f05fbd 
Fix #584, Set Revision to 99 for development builds
@yammajamma yammajamma mentioned this issue Sep 17, 2020
Merged
This was referenced Oct 13, 2020
Merged
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#584 from skliper/fix335-shell-unsigned-bug
8ed578e 
Fix nasa#335: Shell unsigned pkt length bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco