Fix empty ∆FP output

jpiper · Jan 17, 2016 · 84ff434 · 84ff434
1 parent 00167d7
commit 84ff434
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,3 +1,7 @@
+0.2.3 - 2016-01--17
+==================
+* BUG: Fix error in ``wellington_bootstrap.py`` which caused no output to be written to disk (thanks to Duy Pham for reporting)
+
 0.2.2 - 2015-12-26
 ==================
 * BUG: Fix error in ``wellington_bootstrap.py``

diff --git a/pyDNase/_version.py b/pyDNase/_version.py
@@ -1 +1 @@
-__version__ = "0.2.2"
+__version__ = "0.2.3"
diff --git a/pyDNase/scripts/wellington_bootstrap.py b/pyDNase/scripts/wellington_bootstrap.py
@@ -75,7 +75,7 @@ def footprints(self, withCutoff = -20, merge = 1):
             merged_ranges = []
             while len(ranges):
                 # Find best score
-                sorted(ranges, key=lambda x: -x[2])
+                ranges.sort(key=lambda x: -x[2])
                 # Take the last value
                 best = ranges.pop()
                 merged_ranges.append(best)
@@ -85,8 +85,6 @@ def footprints(self, withCutoff = -20, merge = 1):
                     if not c <= best[1] <= d:
                         new_ranges.append([c, d, e, f])
                 ranges = new_ranges
-            else:
-                 merged_ranges = ranges
             # Creates reads GenomicIntervalSet and adds the footprints to them
             for i in merged_ranges:
                 return_set.append(((i[0] + i[1])/2, i[3]))