Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #2

Closed
sindresorhus opened this issue Apr 16, 2013 · 3 comments
Closed

Tests #2

sindresorhus opened this issue Apr 16, 2013 · 3 comments
Milestone

Comments

@sindresorhus
Copy link

For obvious reasons.

Since you claim it's performant, it should also contain benchmark tests.

@jpmonette
Copy link
Owner

Might be added in a future update. The performant argument is more in term of functionality. This is a really simple functionality, but not available elsewhere. There are some RSS generators, but none generating both at the same time, on request. Might add RDFa support in the future.

@staxmanade
Copy link

Thanks for the project - code is clean and readable.

Regarding tests - a good testing tool for this type of project is https://github.com/approvals/ApprovalTests.NodeJS. Would allow you to generate some simple tests and avoid regressions going forward.

You could take your home-page getting-started sample - turn that into a single test and use approvals to create a snapshot to verify future changes against.

@staxmanade staxmanade mentioned this issue May 5, 2014
@sindresorhus
Copy link
Author

The performant argument is more in term of functionality.

Then make that more clear ;)

@jpmonette jpmonette added this to the Tests milestone Oct 14, 2015
agates referenced this issue in agates/feed-podcast Dec 28, 2022
- adding mandatory attribute to enclosure image, which fixes Chocobozzz#2
- adding missing namespace when using media:thumbnail, which fixes jpmonette#3

1.1.7
Chocobozzz referenced this issue in Chocobozzz/feed May 10, 2023
* add custom fields

* adding torrent enclosure support

* added support for torrent via arrays/objects/MRSS

* added babel support for rest operator and target node 8 (as used in peertube)

* hotfix: adding proper namespaces and better torrent object handling

1.1.4

* adding support for media:group and moving from peerLink to more complete media:content

1.1.5

* adding support for media:thumbnail

1.1.6

* fixing spec inconsitencies with image enclosure and mrss

- adding mandatory attribute to enclosure image, which fixes #2
- adding missing namespace when using media:thumbnail, which fixes jpmonette#3

1.1.7

* (fix) increment package version

* (mrss) implement additional properties in the item scope for jpmonette#10

- media:categories
- media:community
  - media:statistics
  - media:starRating
- media:keywords
- media:embed
- media:player
- media:subTitle

* (lint) reformatting code for readability

using prettier

* support rich group properties, fix peerLink

BREAKING: torrent was considered as media:content instead of the specified
media:peerLink

resolves jpmonette#10

1.1.9

* (fix) increment package version

* (fix) hash property

* (fix) deal with empty category value

1.1.11

* Update babel/jest

* Add initial podcast namespace support

* Change package for test publishing on NPM

* Re-add content namespace

* 1.2.2

* Fix itunes:image to use href attribute on podcast

* 1.2.3

* Replace title attribute with optional height

Title was mostly meaningless and height is much more obvious while still optional.

* 1.3.0

* Update gitignore for intellij/webstorm

* Add base .idea project files

* 1.4.0

* Add managingEditor, webMaster, itunes:owner

* Add socialInteract, medium

* Update dependencies

* Start version 1.5.0

* Add support for podcast:liveItem and experimental podcast:tracker

* 1.5.1

* Add title attribute to alternateEnclosure

* 1.5.2

* Add podcast:locked tag

* Add experimental podcast:categories on channel and items

* 1.6.0

* Don't generate categories with empty list

* 1.6.1

* Initial commit for podcast feeds using The Podcast Namespace

* Remove old JS files

* Add support for custom tags not built in

* Fix person/locked/explicit

* Version 6.1.1 for packaging changes

* Update sanitized attributes

* Version 6.1.2

* Revert package.json for upstream merge

* Remove .idea folder

* Remove old package-lock.json

* Remove extra files

* Remove .idea folder

* Remove old package-lock.json

* Remove extra files

* alternateEnclosure language attribute should be "lang"

* alternateEnclosure language attribute should be "lang"

* Add support for custom XMLNS definitions

* Add STUN server listing for podcast feeds, add trackers to channel

---------

Co-authored-by: Rigel Kent <sendmemail@rigelk.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants