Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample tests #21

Closed
wants to merge 7 commits into from
Closed

Sample tests #21

wants to merge 7 commits into from

Conversation

staxmanade
Copy link

I commented earlier on #2 and threw together a quick sample test using Approvals.

Note 1: it would be better to use something like Jasmine or Mocha (I like Mocha) to set each test instead of a single node.js script - but it's the simplest thing at the moment.

Note 2: I was struggling with line-endings. I put a simple .gitattributes in and re-set the files. I tried to make the commits meaningful. While looking at the diff of all won't help (due to line-endings changes). other commits should give context of changes.

Note 3: Would be good to put other sample data/posts into the test and verify the output is correct (saving the *.approved.txt files.

If you merge this commit you could then run npm test to execute your tests.

Hope this helps.

@take-cheeze
Copy link

👍 👍 👍
Feed validator test should pass with staxmanade@0081a85.

@take-cheeze
Copy link

I've referenced RFC and Wikipedia example.
BTW it seems like link tag with rel="alternate" attribute doesn't need to be generated since link tag without rel attribute is already generated from same options.link.

@take-cheeze
Copy link

@staxmanade Thanks for the update.
Having tests is nice. :)

@jpmonette
Copy link
Owner

This pull request has an impact on two many files - it seems like you've overidden the indentation at the same item.

@jpmonette jpmonette closed this Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants