Some basic settings for vscode #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the start of the work to automate project settings in IDEs. This PR makes it so that every modular project, when opened in vscode, gets a recommendation to install the eslint plugin, some editor settings, and a pointer to typescript so it picks up the right version. We'll expand on this in the future.
|
added 3 commits
December 22, 2020 14:41
… setupEnvironment wasn't being copied over
|
LGTM - progress is progress. |
|
dammit, should've added a changeset to this. |
threepointone
pushed a commit
that referenced
this pull request
Dec 23, 2020
LukeSheard
pushed a commit
that referenced
this pull request
Dec 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of the work to automate project settings in IDEs. This PR makes it so that every modular project, when opened in vscode, gets a recommendation to install the eslint plugin, some editor settings, and a pointer to typescript so it picks up the right version. We'll expand on this in the future.
Closes #68, but we'll do more in the future.
Additionally: while working on this, I discovered and fixed a bug where we weren't copying over all files from the template when creating a new project.