Node version 20 #56
Open
Node version 20 #56
+132
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec62169.
|
@jpribyl any chance you can help this get merged in? Thanks! 🙇 |
|
@GrantBirki yeah, although a number of tests are failing-- we might need to have a look at breaking changes from node 16--20 and see what else (if anything) needs updating! |
|
@jpribyl any updates here? |
|
Need some help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also saw the Node 16 warning in Issue #54
I've bumped to Node 20 and also updated package.json.
But to get this PR's build working, I think the push-prebuilt-action PR needs merging first.
I'm also trying to remember how to test this... it's been a while. Is it enough that the various Github Actions run successfully?